Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 7606029: WebUI TaskManager: Supports background-page mode. (Closed)

Created:
9 years, 4 months ago by yoshiki
Modified:
9 years, 4 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

WebUI TaskManager: Supports background page mode. A background-page-moded Task Manager can be lunched by selecting "View Background Pages (xx)" on the menu, which is shown only when any background page is present. When background-page mode is enabled, the row of background tasks are hi-lighted. BUG=chromium-os:13885 TEST=manual on chromeos-chrome in Linux Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96746

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -13 lines) Patch
M chrome/browser/resources/shared/js/cr/ui/table.js View 1 chunk +20 lines, -0 lines 0 comments Download
M chrome/browser/resources/shared/js/cr/ui/table/table_list.js View 1 chunk +7 lines, -3 lines 1 comment Download
M chrome/browser/resources/task_manager/main.js View 3 chunks +28 lines, -2 lines 3 comments Download
M chrome/browser/resources/task_manager/task_manager.css View 1 chunk +6 lines, -0 lines 1 comment Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +11 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/task_manager_dialog.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/task_manager_dialog.cc View 5 chunks +20 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/task_manager_handler.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
yoshiki
Please review this!
9 years, 4 months ago (2011-08-11 05:52:23 UTC) #1
xiyuan
9 years, 4 months ago (2011-08-11 17:14:13 UTC) #2
LGTM with nits

http://codereview.chromium.org/7606029/diff/1/chrome/browser/resources/shared...
File chrome/browser/resources/shared/js/cr/ui/table/table_list.js (right):

http://codereview.chromium.org/7606029/diff/1/chrome/browser/resources/shared...
chrome/browser/resources/shared/js/cr/ui/table/table_list.js:73:
renderFunction_: function(dataItem, table) {
nit: prefer table as the first arg.

http://codereview.chromium.org/7606029/diff/1/chrome/browser/resources/task_m...
File chrome/browser/resources/task_manager/main.js (right):

http://codereview.chromium.org/7606029/diff/1/chrome/browser/resources/task_m...
chrome/browser/resources/task_manager/main.js:97: this.background_mode =
(location.hash == '#bg');
nit: background_mode -> backgroundMode

http://codereview.chromium.org/7606029/diff/1/chrome/browser/resources/task_m...
chrome/browser/resources/task_manager/main.js:97: this.background_mode =
(location.hash == '#bg');
Could we pass backgroundMode from outside instead of referencing location.hash
in here?

http://codereview.chromium.org/7606029/diff/1/chrome/browser/resources/task_m...
chrome/browser/resources/task_manager/main.js:235: var cm =
this.table_.columnModel;
Should we use table instread of this.table_?

http://codereview.chromium.org/7606029/diff/1/chrome/browser/resources/task_m...
File chrome/browser/resources/task_manager/task_manager.css (right):

http://codereview.chromium.org/7606029/diff/1/chrome/browser/resources/task_m...
chrome/browser/resources/task_manager/task_manager.css:95: background-image:
-webkit-linear-gradient(rgba(255, 255, 255, 0.8), rgba(255, 255, 255, 0));
nit: 80 col?

Powered by Google App Engine
This is Rietveld 408576698