Pass per-script fonts to WebKit settings.

chrome/common/pref_names.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/pref_names.h"
 
 namespace prefs {
 
 // *************** PROFILE PREFS ***************
 // These are attached to the user profile
@@ skipping 92 matching lines @@
 const char kPopupWhitelistedHosts[] = "profile.popup_whitelisted_sites";
 
 // WebKit preferences.
 const char kWebKitStandardFontFamily[] = "webkit.webprefs.standard_font_family";
 const char kWebKitFixedFontFamily[] = "webkit.webprefs.fixed_font_family";
 const char kWebKitSerifFontFamily[] = "webkit.webprefs.serif_font_family";
 const char kWebKitSansSerifFontFamily[] =
     "webkit.webprefs.sansserif_font_family";
 const char kWebKitCursiveFontFamily[] = "webkit.webprefs.cursive_font_family";
 const char kWebKitFantasyFontFamily[] = "webkit.webprefs.fantasy_font_family";
+const char kWebKitStandardFontFamilyMap[] =
+    "webkit.webprefs.standard_font_family_map";
+const char kWebKitFixedFontFamilyMap[] =
+    "webkit.webprefs.fixed_font_family_map";
+const char kWebKitSerifFontFamilyMap[] =
+    "webkit.webprefs.serif_font_family_map";
+const char kWebKitSansSerifFontFamilyMap[] =
+    "webkit.webprefs.sansserif_font_family_map";
+const char kWebKitCursiveFontFamilyMap[] =
+    "webkit.webprefs.cursive_font_family_map";
+const char kWebKitFantasyFontFamilyMap[] =
+    "webkit.webprefs.fantasy_font_family_map";

[jungshik at Google, 2011/08/15 22:50:40]

I wonder if we can use the following names/hierarchy:

webkit.webprefs.fonts.<css generic> instead of the current
webkit.webprefs.{cursive,serif,sans-serif,...}_font_family

webkit.webprefs.fonts.{sans-serif,serif, ....}.<script>  : for per-script font
prefs...

Or, can we use the following instead? Perhaps, not given the way these values
are read/written? 

webkit.webprefs.fonts.<script>.<css generic> ? 

Well, either of these does not change any functionality, but it seems tidier (on
the other hand, we lose the 'direct' name mapping between our preference and
webkit settings). 

[falken, 2011/08/16 07:46:44]

I don't know if we can change the current
  webkit.webprefs.{cursive,serif,sans-serif,...}_font_family
without losing the existing user prefs.

In the latest patch, I've put the new per-script settings in:
webkit.webprefs.fonts.<css generic>.<script>

It might be ugly to have these under "fonts" without the original settings under
fonts as well.  On the other hand, it is really only noticeable if you look at
the Preferences file.  Furthermore, if we add USCRIPT_COMMON ("Zyyy") to the
list of supported scripts, the current
webkit.webprefs.{cursive,serif,sans-serif,...}_font_family preferences could be
superseded by the new webkit.webprefs.fonts.<css generic>.Zyyy preferences.
This is also possible.  Is one more preferable than the other?  I decided to do
<css generic>.<script> since it is more consistent with WebPreferences and
webkit settings, as you say.

+
+// TODO(falken): Add all the scripts we should support.

[jungshik at Google, 2011/08/15 22:50:40]

When we add 30+ scripts later, we may have to use a code generating script :-) 

+const char* kWebKitScriptsForFontFamilyMaps[] =
+    { "Cyrl", "Hang", "Hans", "Hant", "Hrkt" };

[jungshik at Google, 2011/08/15 22:50:40]

As a pilot implementation, can you use 'Arab' rather than 'Cyrl'?  Using 'Arab'
will fix a real bug on CrOS right away. 

sans-serif: Droid Arabic Naskh
serif : Droid Arabic Kufic
standard: Droid Arabic Naskh 

(sans-serif and serif are reveresed because that's what Arabic speakers want). 

[falken, 2011/08/16 07:46:44]

Done.  I used "Droid Arabic Kufi" instead of Kufic since i don't see Kufic on
Chrome OS.

+const size_t kWebKitScriptsForFontFamilyMapsLength =
+   sizeof(kWebKitScriptsForFontFamilyMaps) /
+   sizeof(kWebKitScriptsForFontFamilyMaps[0]);

[tony, 2011/08/15 23:08:28]

Can we use the arraysize() macro in base/basictypes.h here?

[falken, 2011/08/16 07:46:44]

Done.

+
+const char kWebKitStandardFontFamilyJapanese[] =
+    "webkit.webprefs.standard_font_family_map.Hrkt";
+const char kWebKitFixedFontFamilyJapanese[] =
+    "webkit.webprefs.fixed_font_family_map.Hrkt";
+const char kWebKitSerifFontFamilyJapanese[] =
+    "webkit.webprefs.serif_font_family_map.Hrkt";
+const char kWebKitSansSerifFontFamilyJapanese[] =
+    "webkit.webprefs.sansserif_font_family_map.Hrkt";
+const char kWebKitStandardFontFamilyKorean[] =
+    "webkit.webprefs.standard_font_family_map.Hang";
+const char kWebKitFixedFontFamilyKorean[] =
+    "webkit.webprefs.fixed_font_family_map.Hang";
+const char kWebKitSerifFontFamilyKorean[] =
+    "webkit.webprefs.serif_font_family_map.Hang";
+const char kWebKitSansSerifFontFamilyKorean[] =
+    "webkit.webprefs.sansserif_font_family_map.Hang";
+const char kWebKitStandardFontFamilySimplifiedHan[] =
+    "webkit.webprefs.standard_font_family_map.Hans";
+const char kWebKitFixedFontFamilySimplifiedHan[] =
+    "webkit.webprefs.fixed_font_family_map.Hans";
+const char kWebKitSerifFontFamilySimplifiedHan[] =
+    "webkit.webprefs.serif_font_family_map.Hans";
+const char kWebKitSansSerifFontFamilySimplifiedHan[] =
+    "webkit.webprefs.sansserif_font_family_map.Hans";
+const char kWebKitStandardFontFamilyTraditionalHan[] =
+    "webkit.webprefs.standard_font_family_map.Hant";
+const char kWebKitFixedFontFamilyTraditionalHan[] =
+    "webkit.webprefs.fixed_font_family_map.Hant";
+const char kWebKitSerifFontFamilyTraditionalHan[] =
+    "webkit.webprefs.serif_font_family_map.Hant";
+const char kWebKitSansSerifFontFamilyTraditionalHan[] =
+    "webkit.webprefs.sansserif_font_family_map.Hant";
+
 const char kWebKitDefaultFontSize[] = "webkit.webprefs.default_font_size";
 const char kWebKitDefaultFixedFontSize[] =
     "webkit.webprefs.default_fixed_font_size";
 const char kWebKitMinimumFontSize[] = "webkit.webprefs.minimum_font_size";
 const char kWebKitMinimumLogicalFontSize[] =
     "webkit.webprefs.minimum_logical_font_size";
 const char kWebKitJavascriptEnabled[] = "webkit.webprefs.javascript_enabled";
 const char kWebKitWebSecurityEnabled[] = "webkit.webprefs.web_security_enabled";
 const char kWebKitJavascriptCanOpenWindowsAutomatically[] =
     "webkit.webprefs.javascript_can_open_windows_automatically";
@@ skipping 1344 matching lines @@
 // Whether user-specified handlers for protocols and content types can be
 // specified.
 const char kCustomHandlersEnabled[] = "custom_handlers.enabled";
 
 // Integers that specify the policy refresh rate for device- and user-policy in
 // milliseconds. Not all values are meaningful, so it is clamped to a sane range
 // by the cloud policy subsystem.
 const char kDevicePolicyRefreshRate[] = "policy.device_refresh_rate";
 const char kUserPolicyRefreshRate[] = "policy.user_refresh_rate";
 }  // namespace prefs