Support OUTDIR variable for tests triggered by Makefile

Support OUTDIR variable for tests triggered by Makefile

TEST="make -j16 check OUTDIR=whatever" works as expected

Committed: http://code.google.com/p/v8/source/detail?r=8871

[Jakob Kummerow, 2011-08-10 09:44:56]

PTAL. Or just try it locally ;-)

[William Hesse, 2011-08-10 10:23:20]

LGTM.  The linter does not like the tabs in the makefile - are those necessary?

Is this also switching from shell to d8 in running the tests?

[Jakob Kummerow, 2011-08-10 10:46:26]

On 2011/08/10 10:23:20, William Hesse wrote:
> LGTM.  The linter does not like the tabs in the makefile - are those
necessary?

http://www.gnu.org/software/make/manual/make.html#Rule-Introduction says:
"Please note: you need to put a tab character at the beginning of every recipe
line! This is an obscurity that catches the unwary. If you prefer to prefix your
recipes with a character other than tab, you can set the .RECIPEPREFIX variable
to an alternate character (see Special Variables)."

I'd prefer to not deviate from the general rule, but I don't feel strongly about
it.

> Is this also switching from shell to d8 in running the tests?

Yes. tools/test.py has had its default changed to d8 a few weeks ago;
tools/test-wrapper-gypbuild.py temporarily regressed this because it overrode
the default (because I had written it before the migration); now the two do the
same thing again. 

(As I've said before, I plan to eventually merge test.py and
test-wrapper-gypbuild.py, but for the transitionary period I think it's good to
best the original script working as it always has.)

[Jakob Kummerow, 2011-08-10 10:50:21]

On 2011/08/10 10:46:26, jkummerow wrote:
> On 2011/08/10 10:23:20, William Hesse wrote:
> > LGTM.  The linter does not like the tabs in the makefile - are those
> necessary?
> 
> http://www.gnu.org/software/make/manual/make.html#Rule-Introduction says:
> "Please note: you need to put a tab character at the beginning of every recipe
> line! This is an obscurity that catches the unwary. If you prefer to prefix
your
> recipes with a character other than tab, you can set the .RECIPEPREFIX
variable
> to an alternate character (see Special Variables)."
> 
> I'd prefer to not deviate from the general rule, but I don't feel strongly
about
> it.

Update: .RECIPEPREFIX is only supported since make 3.82, but Ubuntu Lucid
contains 3.81. So we don't have a choice for the time being.