Issue 7606011: Track usage per-origin at the lowest level instead of per-host.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7606011: Track usage per-origin at the lowest level instead of per-host. (Closed)

Created:
9 years, 4 months ago by michaeln

Modified:
9 years, 4 months ago

Reviewers:
kinuko

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Track usage per-origin at the lowest level instead of per-host. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96475

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+126 lines, -120 lines)			Patch
M	webkit/quota/quota_manager.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/quota/quota_manager.cc	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/quota/usage_tracker.h	View	1 2 3	1 chunk	+20 lines, -10 lines	0 comments	Download
M	webkit/quota/usage_tracker.cc	View	1 2 3	9 chunks	+104 lines, -110 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

michaeln

Hi Kinuko, This is groundwork to fix the bug around app/extension (un)install altering the set ...

9 years, 4 months ago (2011-08-09 23:11:56 UTC) #1

kinuko

9 years, 4 months ago (2011-08-11 15:35:16 UTC) #2

lgtm!

http://codereview.chromium.org/7606011/diff/6001/webkit/quota/usage_tracker.cc
File webkit/quota/usage_tracker.cc (right):

http://codereview.chromium.org/7606011/diff/6001/webkit/quota/usage_tracker.c...
webkit/quota/usage_tracker.cc:402: NewCallback(this,
&ClientUsageTracker::NoopHostUsageCallback));
nice simplification.

http://codereview.chromium.org/7606011/diff/6001/webkit/quota/usage_tracker.c...
webkit/quota/usage_tracker.cc:461: HostUsageMap::const_iterator found  =
cached_usage_.find(host);
nit: extra space between found and =

Expand Messages | Collapse Messages