Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 7606005: Make sure /PROFILE is off when linking the mini_installer (Windows) (Closed)

Created:
9 years, 4 months ago by Roger McFarlane (Google)
Modified:
9 years, 4 months ago
CC:
chromium-reviews, darin (slow to review)
Visibility:
Public.

Description

Make sure /PROFILE is off when linking the mini_installer (Windows) The mini_installer is linked with /FIXED to avoid creating RELOCs, saving size (about 3K ... is it worth it?). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96235

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/installer/mini_installer.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Roger McFarlane (Google)
Found another /PROFILE conflict.
9 years, 4 months ago (2011-08-09 20:31:25 UTC) #1
Sigurður Ásgeirsson
lgtm
9 years, 4 months ago (2011-08-09 20:33:08 UTC) #2
M-A Ruel
lgtm
9 years, 4 months ago (2011-08-09 20:33:30 UTC) #3
cpu_(ooo_6.6-7.5)
On 2011/08/09 20:33:30, Marc-Antoine Ruel wrote: > lgtm to your question, the mini_installer.exe without the ...
9 years, 4 months ago (2011-08-10 00:52:40 UTC) #4
commit-bot: I haz the power
Try job failure for 7606005-1 (retry) on mac for step "ui_tests" (clobber build). It's a ...
9 years, 4 months ago (2011-08-10 19:52:42 UTC) #5
M-A Ruel
On 2011/08/10 19:52:42, I haz the power (commit-bot) wrote: > Try job failure for 7606005-1 ...
9 years, 4 months ago (2011-08-10 19:53:30 UTC) #6
commit-bot: I haz the power
9 years, 4 months ago (2011-08-10 22:36:25 UTC) #7
Change committed as 96235

Powered by Google App Engine
This is Rietveld 408576698