Issue 7606001: Restored download progress, and cleaned up terminal messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7606001: Restored download progress, and cleaned up terminal messages. (Closed)

Created:
9 years, 4 months ago by szager

Modified:
9 years, 3 months ago

Reviewers:
Robert Sesek, Nico, szager1

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Restored download progress, and cleaned up terminal messages. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96027

Patch Set 3 : nit #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -9 lines)			Patch
	M	tools/bisect-builds.py	View	1 2	7 chunks	+43 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nico

LGTM Nice! http://codereview.chromium.org/7606001/diff/2001/tools/bisect-builds.py File tools/bisect-builds.py (right): http://codereview.chromium.org/7606001/diff/2001/tools/bisect-builds.py#newcode332 tools/bisect-builds.py:332: FetchRevision(context, rev, zipfile, None, progress_event) I'd do ...

9 years, 4 months ago (2011-08-09 18:34:08 UTC) #2

szager1

nit http://codereview.chromium.org/7606001/diff/2001/tools/bisect-builds.py File tools/bisect-builds.py (right): http://codereview.chromium.org/7606001/diff/2001/tools/bisect-builds.py#newcode332 tools/bisect-builds.py:332: FetchRevision(context, rev, zipfile, None, progress_event) On 2011/08/09 18:34:08, ...

9 years, 4 months ago (2011-08-09 18:39:06 UTC) #3

Thank you again for implementing this. That is all :-)

Expand Messages | Collapse Messages

Issue 7606001: Restored download progress, and cleaned up terminal messages. (Closed)

Description

Patch Set 1 #

Patch Set 2 : nit #

Patch Set 3 : nit #

Messages