src/untrusted/irt/irt_entry_ppapi.c - Issue 7605029: Extend IRT with nacl_irt_resource_open interface

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/untrusted/irt/irt_entry_ppapi.c

Issue 7605029: Extend IRT with nacl_irt_resource_open interface (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/

Patch Set: '' Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 /*

	2 * Copyright (c) 2011 The Native Client Authors. All rights reserved.

	3 * Use of this source code is governed by a BSD-style license that can be

	4 * found in the LICENSE file.

	5 */

	6

	7 #include "native_client/src/shared/ppapi_proxy/ppruntime.h"

	8

	9 __attribute__((constructor)) void CallIRTInit() {
	pasko-google - do not use 2011/08/15 16:23:04 you could write a clarifying comment saying that i you could write a clarifying comment saying that it is possible to initialize the manifest channel lazily, but it would require constructing a mutex halyavin 2011/08/16 09:05:37 I don't think that we need to comment all roads no Show quoted text On 2011/08/15 16:23:04, pasko wrote: > you could write a clarifying comment saying that it is possible to initialize > the manifest channel lazily, but it would require constructing a mutex I don't think that we need to comment all roads not taken in the comments. I added more reasons for eager initialization in the answer to Roland.
	10 if (IRTInit()) {

	11 static const char fatal_msg[] =

	12 "irt initialization (IRTInit) failed.\n";

	13 write(2, fatal_msg, sizeof(fatal_msg) - 1);

	14 _exit(-1);

	15 }

	16 }

OLD	NEW