Issue 7605028: Add support for content unit tests to memory bot scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7605028: Add support for content unit tests to memory bot scripts (Closed)

Created:
9 years, 4 months ago by jochen (gone - plz use gerrit)

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, Timur Iskhodzhanov

CC:
chromium-reviews, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Add support for content unit tests to memory bot scripts BUG=90443 TEST=none

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	tools/heapcheck/chrome_tests.py	View		2 chunks	+4 lines, -0 lines	0 comments	Download
	M	tools/valgrind/chrome_tests.py	View		2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Timur Iskhodzhanov

Is it like more like unit_tests or like ui_tests? I mean does it spawn a ...

9 years, 4 months ago (2011-08-10 13:44:12 UTC) #2

jochen (gone - plz use gerrit)

currently, the content_unittests binary does nothing. I will move tests from unit_tests to content_unittests, so ...

9 years, 4 months ago (2011-08-10 13:53:37 UTC) #3

Timur Iskhodzhanov

Great, LGTM++ On 2011/08/10 13:53:37, jochen wrote: > currently, the content_unittests binary does nothing. I ...

9 years, 4 months ago (2011-08-10 14:12:43 UTC) #4

commit-bot: I haz the power

9 years, 4 months ago (2011-08-10 19:50:57 UTC) #5

Can't apply patch for file tools/heapcheck/chrome_tests.py.
While running patch -p1 --forward --force;
patching file tools/heapcheck/chrome_tests.py
Hunk #1 FAILED at 83.
Hunk #2 succeeded at 266 with fuzz 2 (offset 4 lines).
1 out of 2 hunks FAILED -- saving rejects to file
tools/heapcheck/chrome_tests.py.rej

Expand Messages | Collapse Messages