views: Force child views to paint into their own texture when the parent has an external texture.

views: Force child views to paint into their own texture when the parent has an external texture.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96177

[sadrul, 2011-08-10 05:31:04]

I believe this is the fix we agreed on? I haven't been able to test it (I get a
crash with --force-compositing-mode over NX), so perhaps you could test it and
see if it works right? :-)

[jonathan.backer, 2011-08-10 14:24:22]

On 2011/08/10 05:31:04, sadrul wrote:
> I believe this is the fix we agreed on? I haven't been able to test it (I get
a
> crash with --force-compositing-mode over NX), so perhaps you could test it and
> see if it works right? :-)

LGTM

I've tested and it fixes the issues with combo boxes.

[rjkroege, 2011-08-10 14:29:53]

LGTM

http://codereview.chromium.org/7605024/diff/1/views/view.cc
File views/view.cc (right):

http://codereview.chromium.org/7605024/diff/1/views/view.cc#newcode1237
views/view.cc:1237: (*i)->SetPaintToLayer(true);
this is not recursive right? It's only the immediate children?

[jonathan.backer, 2011-08-10 14:30:46]

> views/view.cc:1237: (*i)->SetPaintToLayer(true);
> this is not recursive right? It's only the immediate children?

Yes.

[sadrul, 2011-08-10 14:33:05]

http://codereview.chromium.org/7605024/diff/1/views/view.cc
File views/view.cc (right):

http://codereview.chromium.org/7605024/diff/1/views/view.cc#newcode1237
views/view.cc:1237: (*i)->SetPaintToLayer(true);
On 2011/08/10 14:29:53, rjkroege wrote:
> this is not recursive right? It's only the immediate children?

Yes, that is correct (i.e. not recursive).