crypto/sha2.h - Issue 7605019: Reduce number of unnamed-type-template-args violations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: crypto/sha2.h

Issue 7605019: Reduce number of unnamed-type-template-args violations. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: crypto/sha2.h

===================================================================

--- crypto/sha2.h (revision 98480)

+++ crypto/sha2.h (working copy)

@@ -16,7 +16,7 @@

// Functions for SHA-384 and SHA-512 can be added when the need arises.

-enum {

+enum Constants {

wtc 2011/08/26 21:20:53 Would you be willing to name this enum ClangWarnsI

Peter Kasting 2011/08/26 21:32:51 No, for various reasons, not least that Clang does

SHA256_LENGTH = 32 // length in bytes of a SHA-256 hash

};