Chromium Code Reviews| Index: net/proxy/proxy_config.h |
| =================================================================== |
| --- net/proxy/proxy_config.h (revision 97489) |
| +++ net/proxy/proxy_config.h (working copy) |
| @@ -110,7 +110,7 @@ |
| typedef int ID; |
| // Indicates an invalid proxy config. |
| - enum { INVALID_ID = 0 }; |
| + static const ID kInvalidConfigID; |
|
wtc
2011/08/24 01:18:53
Nit: please shorten this to kInvalidID.
Peter Kasting
2011/08/24 01:29:22
I did at first, but it turns out there's a naming
|
| ProxyConfig(); |
| ProxyConfig(const ProxyConfig& config); |
| @@ -120,7 +120,7 @@ |
| // Used to numerically identify this configuration. |
| ID id() const { return id_; } |
| void set_id(int id) { id_ = id; } |
| - bool is_valid() const { return id_ != INVALID_ID; } |
| + bool is_valid() const { return id_ != kInvalidConfigID; } |
| // Returns true if the given config is equivalent to this config. |
| bool Equals(const ProxyConfig& other) const; |