Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1570)

Unified Diff: chrome/browser/net/predictor_unittest.cc

Issue 7605019: Reduce number of unnamed-type-template-args violations. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/predictor_unittest.cc
===================================================================
--- chrome/browser/net/predictor_unittest.cc (revision 97489)
+++ chrome/browser/net/predictor_unittest.cc (working copy)
@@ -263,12 +263,12 @@
// Return a motivation_list if we can find one for the given motivating_host (or
// NULL if a match is not found).
-static ListValue* FindSerializationMotivation(
- const GURL& motivation, const ListValue& referral_list) {
+static ListValue* FindSerializationMotivation(const GURL& motivation,
+ const ListValue& referral_list) {
Nico 2011/08/19 20:34:23 This indentation style is strictly worse than the
brettw 2011/08/21 05:37:03 I usually recommend the style applied by the patch
CHECK_LT(0u, referral_list.GetSize()); // Room for version.
int format_version = -1;
CHECK(referral_list.GetInteger(0, &format_version));
- CHECK_EQ(Predictor::PREDICTOR_REFERRER_VERSION, format_version);
+ CHECK_EQ(Predictor::kPredictorReferrerVersion, format_version);
ListValue* motivation_list(NULL);
for (size_t i = 1; i < referral_list.GetSize(); ++i) {
referral_list.GetList(i, &motivation_list);
@@ -284,7 +284,7 @@
static ListValue* NewEmptySerializationList() {
base::ListValue* list = new base::ListValue;
list->Append(
- new base::FundamentalValue(Predictor::PREDICTOR_REFERRER_VERSION));
+ new base::FundamentalValue(Predictor::kPredictorReferrerVersion));
return list;
}

Powered by Google App Engine
This is Rietveld 408576698