Reduce number of unnamed-type-template-args violations.

crypto/sha2_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "crypto/sha2.h"
 
 #include "base/basictypes.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 TEST(Sha256Test, Test1) {
@@ skipping 27 matching lines @@
   int expected1[] = { 0xba, 0x78, 0x16, 0xbf,
                       0x8f, 0x01, 0xcf, 0xea,
                       0x41, 0x41, 0x40, 0xde,
                       0x5d, 0xae, 0x22, 0x23,
                       0xb0, 0x03, 0x61, 0xa3,
                       0x96, 0x17, 0x7a, 0x9c,
                       0xb4, 0x10, 0xff, 0x61,
                       0xf2, 0x00, 0x15, 0xad };
 
   std::string output1 = crypto::SHA256HashString(input1);
-  ASSERT_EQ(crypto::SHA256_LENGTH, output1.size());
+  ASSERT_EQ(static_cast<size_t>(crypto::SHA256_LENGTH), output1.size());

[wtc, 2011/08/26 21:20:53]

Is this static_cast to size_t still necessary?  It seems
that the static_cast<size_t> should allow crypto::SHA256_LENGTH
to be of an unnamed enum type.

[Peter Kasting, 2011/08/26 21:32:51]

Yes.
That may be true, but the point of this change is to minimize the number of
anonymous enums in general, not just to do it to fix warnings (since we're not
re-enabling the warning, this change won't make any difference to warnings).

[wtc, 2011/08/26 22:30:50]

If we are not re-enabling the warning, then we should not
change some of these unnamed enum types.  Some of them
really don't need a name.

Specifically, I'd like to opt out for the following:
1. enum Constants in crypto/sha2.h.
2. enum TrustBits in net/base/cert_database.h.

[wtc, 2011/08/29 20:44:32]

I still want these two files (and the associated .cc files)
removed from this CL.

An unnamed enum is useful when I do not need a name for
the enumeration type.  No code will ever use the 'Constants'
or 'TrustBits' enum type names, so why name them?  The enum
type names will make people wonder if the enum type names
should be used somewhere.

   for (size_t i = 0; i < crypto::SHA256_LENGTH; i++)
     EXPECT_EQ(expected1[i], static_cast<uint8>(output1[i]));
 }
 
 TEST(Sha256Test, Test2) {
   // Example B.2 from FIPS 180-2: multi-block message.
   std::string input2 =
       "abcdbcdecdefdefgefghfghighijhijkijkljklmklmnlmnomnopnopq";
   int expected2[] = { 0x24, 0x8d, 0x6a, 0x61,
                       0xd2, 0x06, 0x38, 0xb8,
@@ skipping 32 matching lines @@
   crypto::SHA256HashString(input3, output3, sizeof(output3));
   for (size_t i = 0; i < crypto::SHA256_LENGTH; i++)
     EXPECT_EQ(expected3[i], static_cast<int>(output3[i]));
 
   uint8 output_truncated3[12];
   crypto::SHA256HashString(input3,
                            output_truncated3, sizeof(output_truncated3));
   for (size_t i = 0; i < sizeof(output_truncated3); i++)
     EXPECT_EQ(expected3[i], static_cast<int>(output_truncated3[i]));
 }