Reduce number of unnamed-type-template-args violations.

ppapi/c/pp_errors.h

 /* Copyright (c) 2011 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /* From pp_errors.idl modified Sat Jul 16 16:50:26 2011. */
 
 #ifndef PPAPI_C_PP_ERRORS_H_
 #define PPAPI_C_PP_ERRORS_H_
 
 #include "ppapi/c/pp_macros.h"
 
 /**
  * @file
  * This file defines an enumeration of all PPAPI error codes.
  */
 
 
 /**
  * @addtogroup Enums
  * @{
  */
 /**
  * This enumeration contains enumerators of all PPAPI error codes.
  * Errors are negative valued.
  */
-enum {
+enum ErrorCodes {

[brettw, 2011/08/21 05:37:03]

This isn't in any namespace so I don't think we want to use this generic name
here!

We've previously discussed having a named enum type here but have decided
against it so far. PPAPI error codes represent either a value from here, or a
positive value representing success (usually number of bytes read or something).
We've been worried that naming this type would encourage people to actually use
it, which would be confusing in some cases.

[Peter Kasting, 2011/08/22 03:56:41]

Oof.  Honestly that seems bad.  Can't you namespace this?  I feel uncomfortable
adding this sort of thing to the global namespace.
That's also true of various other enums I name in this patch, though, such as
the content-and-chrome notification types (where using either type separately is
bad because any function which works with them needs to handle both).  The
downside of not naming the enums is that it is impossible to refer to the type
by name even when you really want to (for example, for a function which has no
return value other than one of these codes) and (until C++11) impossible to pass
these values to templates.

[brettw, 2011/08/22 04:11:08]

This is the public Pepper API which must be compilable in C mode, so no
namespaces. We normally prefix things with PP_, so if we were to name this it
would be PP_Error or something.

   /**
    * This value is returned by a function on successful synchronous completion
    * or is passed as a result to a PP_CompletionCallback_Func on successful
    * asynchronous completion.
    */
   PP_OK = 0,
   /**
    * This value is returned by a function that accepts a PP_CompletionCallback
    * and cannot complete synchronously. This code indicates that the given
    * callback will be asynchronously notified of the final result once it is
@@ skipping 48 matching lines @@
    * expected input.
    */
   PP_ERROR_USERCANCEL = -40
 };
 /**
  * @}
  */
 
 #endif  /* PPAPI_C_PP_ERRORS_H_ */