Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: remoting/protocol/jingle_session.h

Issue 7605018: Simplify channel creation callbacks in remoting::Session interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef REMOTING_PROTOCOL_JINGLE_SESSION_H_ 5 #ifndef REMOTING_PROTOCOL_JINGLE_SESSION_H_
6 #define REMOTING_PROTOCOL_JINGLE_SESSION_H_ 6 #define REMOTING_PROTOCOL_JINGLE_SESSION_H_
7 7
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "base/task.h" 9 #include "base/task.h"
10 #include "crypto/rsa_private_key.h" 10 #include "crypto/rsa_private_key.h"
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 void OnChannelConnectorFinished(const std::string& name, 117 void OnChannelConnectorFinished(const std::string& name,
118 JingleChannelConnector* connector); 118 JingleChannelConnector* connector);
119 119
120 // Creates channels after session has been accepted. 120 // Creates channels after session has been accepted.
121 // TODO(sergeyu): Don't create channels in JingleSession. 121 // TODO(sergeyu): Don't create channels in JingleSession.
122 void CreateChannels(); 122 void CreateChannels();
123 123
124 // Callbacks for the channels created in JingleSession. 124 // Callbacks for the channels created in JingleSession.
125 // TODO(sergeyu): Remove this method once *_channel() methods are 125 // TODO(sergeyu): Remove this method once *_channel() methods are
126 // removed from Session interface. 126 // removed from Session interface.
127 void OnStreamChannelConnected( 127 void OnChannelConnected(scoped_ptr<net::Socket>* socket_container,
128 const std::string& name, net::StreamSocket* socket); 128 net::StreamSocket* socket);
129 void OnChannelConnected(const std::string& name, net::Socket* socket);
130 129
131 const cricket::ContentInfo* GetContentInfo() const; 130 const cricket::ContentInfo* GetContentInfo() const;
132 131
133 void SetState(State new_state); 132 void SetState(State new_state);
134 133
135 // JingleSessionManager that created this session. Guaranteed to 134 // JingleSessionManager that created this session. Guaranteed to
136 // exist throughout the lifetime of the session. 135 // exist throughout the lifetime of the session.
137 JingleSessionManager* jingle_session_manager_; 136 JingleSessionManager* jingle_session_manager_;
138 137
139 // Certificates used for connection. Currently only receiving side 138 // Certificates used for connection. Currently only receiving side
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
186 ScopedRunnableMethodFactory<JingleSession> task_factory_; 185 ScopedRunnableMethodFactory<JingleSession> task_factory_;
187 186
188 DISALLOW_COPY_AND_ASSIGN(JingleSession); 187 DISALLOW_COPY_AND_ASSIGN(JingleSession);
189 }; 188 };
190 189
191 } // namespace protocol 190 } // namespace protocol
192 191
193 } // namespace remoting 192 } // namespace remoting
194 193
195 #endif // REMOTING_PROTOCOL_JINGLE_SESSION_H_ 194 #endif // REMOTING_PROTOCOL_JINGLE_SESSION_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698