Simplify channel creation callbacks in remoting::Session interface.

Simplify channel creation callbacks in remoting::Session interface.

Remove name parameters from StreamChannelCallback and
DatagramChannelCallback. This argument is redundant: callback currying
can be used instead where neccessary.

BUG=None
TEST=compiles.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96310

[Wez, 2011-08-09 23:42:35]

On the face of it this looks reasonable, but it introduces a load of
callback-currying that wouldn't otherwise be necessary.

http://codereview.chromium.org/7605018/diff/1/remoting/protocol/rtp_video_rea...
File remoting/protocol/rtp_video_reader.cc (right):

http://codereview.chromium.org/7605018/diff/1/remoting/protocol/rtp_video_rea...
remoting/protocol/rtp_video_reader.cc:52: void
RtpVideoReader::OnChannelReady(bool rtp, net::Socket* socket) {
Why have an |rtp| bool here, rather than the container scheme you used
elsewhere?

[Sergey Ulanov, 2011-08-10 00:00:43]

> On the face of it this looks reasonable, but it introduces 
> a load of callback-currying that wouldn't otherwise 
> be necessary.
I think that we will not need currying in most cases.
JingleSession::OnChannelConnected() will go away in the future. RTP/RTCP reader
and writer are the only case when will have one callback used for multiple
different channels.

http://codereview.chromium.org/7605018/diff/1/remoting/protocol/rtp_video_rea...
File remoting/protocol/rtp_video_reader.cc (right):

http://codereview.chromium.org/7605018/diff/1/remoting/protocol/rtp_video_rea...
remoting/protocol/rtp_video_reader.cc:52: void
RtpVideoReader::OnChannelReady(bool rtp, net::Socket* socket) {
On 2011/08/09 23:42:35, Wez wrote:
> Why have an |rtp| bool here, rather than the container scheme you used
> elsewhere?

because we also need to initialized |rtp_reader_| and |rtcp_writer_| here.

[Wez, 2011-08-10 00:37:13]

OK, LGTM

http://codereview.chromium.org/7605018/diff/1/remoting/protocol/rtp_video_rea...
File remoting/protocol/rtp_video_reader.cc (right):

http://codereview.chromium.org/7605018/diff/1/remoting/protocol/rtp_video_rea...
remoting/protocol/rtp_video_reader.cc:52: void
RtpVideoReader::OnChannelReady(bool rtp, net::Socket* socket) {
On 2011/08/10 00:00:43, sergeyu wrote:
> On 2011/08/09 23:42:35, Wez wrote:
> > Why have an |rtp| bool here, rather than the container scheme you used
> > elsewhere?
> 
> because we also need to initialized |rtp_reader_| and |rtcp_writer_| here.

Yes, but that could be managed with:
  if (socket == rtp_channel_get())
after the "container" has been set. :)