Implement drag and drop testing in a platform independent way.

chrome/browser/ui/panels/native_panel.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_PANELS_NATIVE_PANEL_H_
 #define CHROME_BROWSER_UI_PANELS_NATIVE_PANEL_H_
 #pragma once
 
 #include "chrome/browser/ui/panels/panel.h"
 #include "ui/gfx/native_widget_types.h"
 
 class FindBar;
 class NativePanelTesting;
+class Panel;

[jianli, 2011/08/09 21:10:23]

We already include panel.h. I think this is removed in jennb's patch.

[prasadt, 2011/08/09 23:05:04]

Done.

 
 namespace gfx {
 class Rect;
 }  // namespace gfx
 
 // An interface for a class that implements platform-specific behavior for panel
 // windows. We use this interface for two reasons:
 // 1. We don't want to use BrowserWindow as the interface between shared panel
 //    code and platform-specific code. BrowserWindow has a lot of methods, most
 //    of which we don't use and simply stub out with NOTIMPLEMENTED().
@@ skipping 31 matching lines @@
   virtual bool IsPanelActive() const = 0;
   virtual gfx::NativeWindow GetNativePanelHandle() = 0;
   virtual void UpdatePanelTitleBar() = 0;
   virtual void ShowTaskManagerForPanel() = 0;
   virtual FindBar* CreatePanelFindBar() = 0;
   virtual void NotifyPanelOnUserChangedTheme() = 0;
   virtual void DrawAttention() = 0;
   virtual bool IsDrawingAttention() const = 0;
   virtual Browser* GetPanelBrowser() const = 0;
   virtual void DestroyPanelBrowser() = 0;
-
-  // Returns a pointer to the testing interface to the native panel.
-  virtual NativePanelTesting* GetNativePanelTesting() = 0;
 };
 
 // A NativePanel utility interface used for accessing elements of the
 // native panel used only by test automation.
 class NativePanelTesting {
  public:
+  static NativePanelTesting* Create(NativePanel* native_panel);
 
- protected:
-  virtual ~NativePanelTesting() {}
+  virtual void TitlebarLeftButtonPress(gfx::Point point) = 0;

[jianli, 2011/08/09 21:10:23]

It would be better to call it either TitlebarLeftButtonPressed or
PressTitlebarLeftButton.

Also, button seems to be vague since it might mean the mouse button or the UI
button. How about calling it TitlebarLeftMouseButtonPressed.

One other thing is about we should make bar capitalized. It seems that we have
mixed use of both Titlebar and TitleBar.

[prasadt, 2011/08/09 23:05:04]

I changed the name to PressLeftMouseButtonTitlebar.  Keeping Titlebar to the end
- I think its makes better grouping of the functions.

TitlebarLeftMouseButtonPressed sounds like an event handler than a verb. 
Titlebar vs TitleBar, you're right we're mixing them up.  I picked Titlebar, I
think of it as one word. 

+  virtual void TitlebarLeftButtonRelease() = 0;
+  virtual void TitlebarDrag(int delta_x, int delta_y) = 0;
+  virtual void TitlebarCancelDrag() = 0;
+  virtual void TitlebarFinishDrag() = 0;
 };
 
 #endif  // CHROME_BROWSER_UI_PANELS_NATIVE_PANEL_H_