Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 7605003: --downloads-new-ui completely disables the download shelf. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: extract_actions Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <iterator> 8 #include <iterator>
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 346 matching lines...) Expand 10 before | Expand all | Expand 10 after
357 "memory-widget", 357 "memory-widget",
358 IDS_FLAGS_MEMORY_WIDGET_NAME, 358 IDS_FLAGS_MEMORY_WIDGET_NAME,
359 IDS_FLAGS_MEMORY_WIDGET_DESCRIPTION, 359 IDS_FLAGS_MEMORY_WIDGET_DESCRIPTION,
360 kOsCrOS, 360 kOsCrOS,
361 #if defined(OS_CHROMEOS) 361 #if defined(OS_CHROMEOS)
362 // This switch exists only on Chrome OS. 362 // This switch exists only on Chrome OS.
363 SINGLE_VALUE_TYPE(switches::kMemoryWidget) 363 SINGLE_VALUE_TYPE(switches::kMemoryWidget)
364 #else 364 #else
365 SINGLE_VALUE_TYPE("") 365 SINGLE_VALUE_TYPE("")
366 #endif 366 #endif
367 },}; 367 },
368 {
369 "disable-download-shelf", // FLAGS:RECORD_UMA
370 IDS_FLAGS_DISABLE_DOWNLOAD_SHELF_NAME,
371 IDS_FLAGS_DISABLE_DOWNLOAD_SHELF_DESCRIPTION,
372 kOsAll - kOsCrOS,
cbentzel 2011/08/10 11:54:54 Nit: Maybe it's just me, but it feels weird to do
benjhayden 2011/08/10 17:09:17 Even better, kOsAll. If we're reimplementing the U
373 SINGLE_VALUE_TYPE(switches::kDisableDownloadShelf)
374 },
375 };
368 376
369 const Experiment* experiments = kExperiments; 377 const Experiment* experiments = kExperiments;
370 size_t num_experiments = arraysize(kExperiments); 378 size_t num_experiments = arraysize(kExperiments);
371 379
372 // Stores and encapsulates the little state that about:flags has. 380 // Stores and encapsulates the little state that about:flags has.
373 class FlagsState { 381 class FlagsState {
374 public: 382 public:
375 FlagsState() : needs_restart_(false) {} 383 FlagsState() : needs_restart_(false) {}
376 void ConvertFlagsToSwitches(PrefService* prefs, CommandLine* command_line); 384 void ConvertFlagsToSwitches(PrefService* prefs, CommandLine* command_line);
377 bool IsRestartNeededToCommitChanges(); 385 bool IsRestartNeededToCommitChanges();
(...skipping 419 matching lines...) Expand 10 before | Expand all | Expand 10 after
797 } 805 }
798 806
799 const Experiment* GetExperiments(size_t* count) { 807 const Experiment* GetExperiments(size_t* count) {
800 *count = num_experiments; 808 *count = num_experiments;
801 return experiments; 809 return experiments;
802 } 810 }
803 811
804 } // namespace testing 812 } // namespace testing
805 813
806 } // namespace about_flags 814 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698