Issue 7604042: Clean up CL to fix the member function comments and to validate the print preview WebUI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7604042: Clean up CL to fix the member function comments and to validate the print preview WebUI. (Closed)

Created:
9 years, 4 months ago by kmadhusu

Modified:
9 years, 4 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Clean up CL to fix the member function comments and to validate the print preview WebUI. BUG=none TEST=print preview works after code changes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96273

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -51 lines)			Patch
M	chrome/browser/printing/print_preview_message_handler.cc	View		5 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview_handler.h	View	1	3 chunks	+22 lines, -26 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview_ui.h	View	1 2 3 4	1 chunk	+18 lines, -21 lines	0 comments	Download

Total messages: 4 (0 generated)

Lei Zhang

Also include the changes from http://codereview.chromium.org/7550063/diff/2002/chrome/browser/ui/webui/print_preview_ui.h

9 years, 4 months ago (2011-08-10 19:48:20 UTC) #2

LGTM stamp