views-desktop: Add the desktop-window as an observer for a widget when it gets added to the desktop.

views-desktop: Add the desktop-window as an observer for a widget when it gets added to the desktop.

This fixes sending keyboard events to the browser in views-desktop.

TBR=sky@chromium.org
BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96126

[sky, 2011-08-17 15:49:12]

http://codereview.chromium.org/7604024/diff/1/views/desktop/desktop_window_vi...
File views/desktop/desktop_window_view.cc (right):

http://codereview.chromium.org/7604024/diff/1/views/desktop/desktop_window_vi...
views/desktop/desktop_window_view.cc:185:
native_widget_view->GetAssociatedWidget()->AddObserver(this);
Shouldn't you only do this during an add? And shouldn't you remove the observer
at some point?

[sadrul, 2011-08-17 15:54:25]

http://codereview.chromium.org/7604024/diff/1/views/desktop/desktop_window_vi...
File views/desktop/desktop_window_view.cc (right):

http://codereview.chromium.org/7604024/diff/1/views/desktop/desktop_window_vi...
views/desktop/desktop_window_view.cc:185:
native_widget_view->GetAssociatedWidget()->AddObserver(this);
On 2011/08/17 15:49:12, sky wrote:
> Shouldn't you only do this during an add?

Indeed. I did that in a subsequent CL.

> And shouldn't you remove the observer
> at some point?

That doesn't seem to be necessary [at the moment?] since we would remove the
observer when the widget is being destroyed, at which point it doesn't matter
even if we don't remove the observer since the destroyed widget will not trigger
any of the callbacks.

[sky, 2011-08-17 17:15:56]

On Wed, Aug 17, 2011 at 8:54 AM,  <sadrul@chromium.org> wrote:
>
>
http://codereview.chromium.org/7604024/diff/1/views/desktop/desktop_window_vi...
> File views/desktop/desktop_window_view.cc (right):
>
>
http://codereview.chromium.org/7604024/diff/1/views/desktop/desktop_window_vi...
> views/desktop/desktop_window_view.cc:185:
> native_widget_view->GetAssociatedWidget()->AddObserver(this);
> On 2011/08/17 15:49:12, sky wrote:
>>
>> Shouldn't you only do this during an add?
>
> Indeed. I did that in a subsequent CL.

Nice!
If this patch is no longer applicable, please close it out.

Thanks,

  -Scott

>> And shouldn't you remove the observer
>> at some point?
>
> That doesn't seem to be necessary [at the moment?] since we would remove
> the observer when the widget is being destroyed, at which point it
> doesn't matter even if we don't remove the observer since the destroyed
> widget will not trigger any of the callbacks.
>
> http://codereview.chromium.org/7604024/
>