Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6210)

Unified Diff: chrome/renderer/safe_browsing/phishing_term_feature_extractor.cc

Issue 7604022: Fix valgrind failures in PhishingTermFeatureExtractor and remove supressions for said failures. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Clear cache on timeout. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/valgrind/memcheck/suppressions.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/safe_browsing/phishing_term_feature_extractor.cc
diff --git a/chrome/renderer/safe_browsing/phishing_term_feature_extractor.cc b/chrome/renderer/safe_browsing/phishing_term_feature_extractor.cc
index 3b4ba85ea3f87bbd8ad20e4ef233de583d4d46a9..2c4c9902f7fdfbb3ec62dc7772e5cf3764f360e0 100644
--- a/chrome/renderer/safe_browsing/phishing_term_feature_extractor.cc
+++ b/chrome/renderer/safe_browsing/phishing_term_feature_extractor.cc
@@ -177,6 +177,7 @@ void PhishingTermFeatureExtractor::ExtractFeaturesWithTimeout() {
DLOG(ERROR) << "Feature extraction took too long, giving up";
// We expect this to happen infrequently, so record when it does.
UMA_HISTOGRAM_COUNTS("SBClientPhishing.TermFeatureTimeout", 1);
+ negative_word_cache_.Clear();
RunCallback(false);
return;
}
« no previous file with comments | « no previous file | tools/valgrind/memcheck/suppressions.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698