Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 7604019: [Sync] Add client-side plumbing for server control of sessions commit delay (Closed)

Created:
9 years, 4 months ago by akalin
Modified:
9 years, 4 months ago
CC:
chromium-reviews, Raghu Simha, ncarter (slow), Paweł Hajdan Jr., tim (not reviewing), idana
Visibility:
Public.

Description

[Sync] Add client-side plumbing for server control of sessions commit delay Add OVERRIDE to a bunch of overridden functions. BUG=91861 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96243

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix compile error and address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -63 lines) Patch
M chrome/browser/sync/engine/sync_scheduler.h View 1 3 chunks +16 lines, -6 lines 0 comments Download
M chrome/browser/sync/engine/sync_scheduler.cc View 1 4 chunks +19 lines, -4 lines 0 comments Download
M chrome/browser/sync/engine/sync_scheduler_unittest.cc View 1 1 chunk +31 lines, -0 lines 0 comments Download
M chrome/browser/sync/engine/syncapi.cc View 1 6 chunks +31 lines, -28 lines 0 comments Download
M chrome/browser/sync/engine/syncer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/sync/engine/syncer_unittest.cc View 7 chunks +20 lines, -8 lines 0 comments Download
M chrome/browser/sync/sessions/sync_session.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/sync/sessions/sync_session_unittest.cc View 2 chunks +12 lines, -7 lines 0 comments Download
M chrome/browser/sync/sessions/test_util.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/sync/sessions/test_util.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/sync/engine/syncer_command_test.h View 1 2 chunks +13 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
akalin
+tim for review
9 years, 4 months ago (2011-08-10 00:46:12 UTC) #1
tim (not reviewing)
LGTM with nits http://codereview.chromium.org/7604019/diff/1/chrome/browser/sync/engine/sync_scheduler.cc File chrome/browser/sync/engine/sync_scheduler.cc (right): http://codereview.chromium.org/7604019/diff/1/chrome/browser/sync/engine/sync_scheduler.cc#newcode140 chrome/browser/sync/engine/sync_scheduler.cc:140: const int kDefaultSessionsCommitDelaySeconds = 10; I ...
9 years, 4 months ago (2011-08-10 18:42:11 UTC) #2
akalin
Commiting http://codereview.chromium.org/7604019/diff/1/chrome/browser/sync/engine/sync_scheduler.cc File chrome/browser/sync/engine/sync_scheduler.cc (right): http://codereview.chromium.org/7604019/diff/1/chrome/browser/sync/engine/sync_scheduler.cc#newcode140 chrome/browser/sync/engine/sync_scheduler.cc:140: const int kDefaultSessionsCommitDelaySeconds = 10; On 2011/08/10 18:42:11, ...
9 years, 4 months ago (2011-08-10 20:10:36 UTC) #3
commit-bot: I haz the power
9 years, 4 months ago (2011-08-10 23:22:30 UTC) #4
Change committed as 96243

Powered by Google App Engine
This is Rietveld 408576698