Sync Promo: Update sign into sync Wrench menu item

Sync Promo: Update sign into sync Wrench menu item

When not signed in the wrench menu says "Sign in to Chrome". When signed in it says "Signed in to Chrome as pat@example.com".

BUG=91009
TEST=Ran and verified that the wrench menu updated after signing into sync.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96225

[sail, 2011-08-10 00:15:30]

miranda: profiles stuff
pkasting: owners approval

[Peter Kasting, 2011-08-10 00:38:43]

LGTM

http://codereview.chromium.org/7604017/diff/1/chrome/browser/ui/toolbar/wrenc...
File chrome/browser/ui/toolbar/wrench_menu_model.cc (right):

http://codereview.chromium.org/7604017/diff/1/chrome/browser/ui/toolbar/wrenc...
chrome/browser/ui/toolbar/wrench_menu_model.cc:286: const string16
short_product_name =
Nit: Why use const on one string but not the other?  Be consistent.

http://codereview.chromium.org/7604017/diff/1/chrome/browser/ui/toolbar/wrenc...
chrome/browser/ui/toolbar/wrench_menu_model.cc:291: } else {
Nit: No else after return.

[sail, 2011-08-10 00:55:33]

http://codereview.chromium.org/7604017/diff/1/chrome/browser/ui/toolbar/wrenc...
File chrome/browser/ui/toolbar/wrench_menu_model.cc (right):

http://codereview.chromium.org/7604017/diff/1/chrome/browser/ui/toolbar/wrenc...
chrome/browser/ui/toolbar/wrench_menu_model.cc:286: const string16
short_product_name =
On 2011/08/10 00:38:43, Peter Kasting wrote:
> Nit: Why use const on one string but not the other?  Be consistent.

Done. Removed the const.

http://codereview.chromium.org/7604017/diff/1/chrome/browser/ui/toolbar/wrenc...
chrome/browser/ui/toolbar/wrench_menu_model.cc:291: } else {
On 2011/08/10 00:38:43, Peter Kasting wrote:
> Nit: No else after return.

Done.

[Miranda Callahan, 2011-08-10 07:52:57]

LGTM.

On 2011/08/10 00:55:33, sail wrote:
>
http://codereview.chromium.org/7604017/diff/1/chrome/browser/ui/toolbar/wrenc...
> File chrome/browser/ui/toolbar/wrench_menu_model.cc (right):
> 
>
http://codereview.chromium.org/7604017/diff/1/chrome/browser/ui/toolbar/wrenc...
> chrome/browser/ui/toolbar/wrench_menu_model.cc:286: const string16
> short_product_name =
> On 2011/08/10 00:38:43, Peter Kasting wrote:
> > Nit: Why use const on one string but not the other?  Be consistent.
> 
> Done. Removed the const.
> 
>
http://codereview.chromium.org/7604017/diff/1/chrome/browser/ui/toolbar/wrenc...
> chrome/browser/ui/toolbar/wrench_menu_model.cc:291: } else {
> On 2011/08/10 00:38:43, Peter Kasting wrote:
> > Nit: No else after return.
> 
> Done.

[commit-bot: I haz the power, 2011-08-10 22:28:04]

Change committed as 96225