Issue 7604014: Renamed authorized_ to connected_ for p2p sockets host.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7604014: Renamed authorized_ to connected_ for p2p sockets host. (Closed)

Created:
9 years, 4 months ago by Sergey Ulanov

Modified:
9 years, 4 months ago

Reviewers:
Wez

CC:
chromium-reviews, joi+watch-content_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Renamed authorized_ to connected_ for p2p sockets host. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96105

Patch Set 2 : update comments #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -11 lines)			Patch
M	content/browser/renderer_host/p2p/socket_host_tcp.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/p2p/socket_host_tcp.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	content/browser/renderer_host/p2p/socket_host_udp.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	content/browser/renderer_host/p2p/socket_host_udp.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Wez

LGTM! http://codereview.chromium.org/7604014/diff/1/content/browser/renderer_host/p2p/socket_host_udp.h File content/browser/renderer_host/p2p/socket_host_udp.h (right): http://codereview.chromium.org/7604014/diff/1/content/browser/renderer_host/p2p/socket_host_udp.h#newcode53 content/browser/renderer_host/p2p/socket_host_udp.h:53: // response. nit: Strictly it also includes peers ...

9 years, 4 months ago (2011-08-10 00:39:20 UTC) #2

Sergey Ulanov

9 years, 4 months ago (2011-08-10 00:50:54 UTC) #3

http://codereview.chromium.org/7604014/diff/1/content/browser/renderer_host/p...
File content/browser/renderer_host/p2p/socket_host_udp.h (right):

http://codereview.chromium.org/7604014/diff/1/content/browser/renderer_host/p...
content/browser/renderer_host/p2p/socket_host_udp.h:53: // response.
On 2011/08/10 00:39:21, Wez wrote:
> nit: Strictly it also includes peers for which we've received relay allocate
> requests or responses?

Done.

Expand Messages | Collapse Messages

Issue 7604014: Renamed authorized_ to connected_ for p2p sockets host. (Closed)

Description

Patch Set 1 #

Patch Set 2 : update comments #

Messages