Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: tools/grit/grit/format/data_pack_unittest.py

Issue 7604012: Remove the length field from the index entries in data pack files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix write Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/grit/grit/format/data_pack.py ('k') | ui/base/resource/data_pack.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/grit/grit/format/data_pack_unittest.py
diff --git a/tools/grit/grit/format/data_pack_unittest.py b/tools/grit/grit/format/data_pack_unittest.py
index 77c4ba130e10763440cf13181262741b637cec35..aa26a2fa31302dcc00dc72844f2d516070d5e077 100644
--- a/tools/grit/grit/format/data_pack_unittest.py
+++ b/tools/grit/grit/format/data_pack_unittest.py
@@ -15,10 +15,14 @@ from grit.format import data_pack
class FormatDataPackUnittest(unittest.TestCase):
def testWriteDataPack(self):
- expected = ('\x02\x00\x00\x00\x04\x00\x00\x00\x01\x000\x00\x00'
- '\x00\x00\x00\x00\x00\x04\x000\x00\x00\x00\x0c\x00\x00\x00'
- '\x06\x00<\x00\x00\x00\x0c\x00\x00\x00\n\x00H\x00'
- '\x00\x00\x00\x00\x00\x00this is id 4this is id 6')
+ expected = (
+ '\x03\x00\x00\x00\x04\x00\x00\x00' # header (version, no. entries)
+ '\x01\x00\x26\x00\x00\x00' # index entry 1
+ '\x04\x00\x26\x00\x00\x00' # index entry 4
+ '\x06\x00\x32\x00\x00\x00' # index entry 6
+ '\x0a\x00\x3e\x00\x00\x00' # index entry 10
+ '\x00\x00\x3e\x00\x00\x00' # extra entry for the size of last
+ 'this is id 4this is id 6') # data
input = { 1: "", 4: "this is id 4", 6: "this is id 6", 10: "" }
output = data_pack.DataPack.WriteDataPack(input)
self.failUnless(output == expected)
« no previous file with comments | « tools/grit/grit/format/data_pack.py ('k') | ui/base/resource/data_pack.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698