atomic_ops_test: Simplify by using joinable threads

atomic_ops_test: Simplify by using joinable threads

Rather than implementing thread joining by hand out of condvars, just
use joinable threads.

Also remove a redundant NaClThreadExit() call.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=2044
TEST=run_atomic_ops_nexe_test

Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=6371

[krasin, 2011-08-09 16:38:46]

On 2011/08/09 16:36:31, Mark Seaborn wrote:

LGTM

[pdox, 2011-08-09 22:14:13]

This change is OK, but it's kind of silly if you are only doing this to hide the
flakiness, which could very well be caused by a race condition in libpthread or
trusted code.

[Mark Seaborn, 2011-08-09 22:50:28]

On 9 August 2011 15:14, <pdox@google.com> wrote:

> This change is OK, but it's kind of silly if you are only doing this to
> hide the
> flakiness, which could very well be caused by a race condition in
> libpthread or
> trusted code.
>

I'm doing it mostly because the code sets a bad example by implementing
joining itself, and I want to clean up the codebase to remove
NaClThreadDtor().

I have no idea whether it will hide the flakiness.  Whether it does or
doesn't, this will tell us something about where the bug lies. :-)

If condvar is flaky in some way, really that should have its own targeted
test, rather than being piggybacked onto this test which isn't specifically
a test for condvars, AIUI.

Cheers,
Mark

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.