Issue 7602017: ntp4: respect non-default apps promo logo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7602017: ntp4: respect non-default apps promo logo (Closed)

Created:
9 years, 4 months ago by Evan Stade

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, Rick Byers

CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

ntp4: respect non-default apps promo logo BUG=none TEST=manual (set logo to something else in preferences file) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96688

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -11 lines)			Patch
M	chrome/browser/resources/ntp4/apps_page.css	View	1 2	2 chunks	+22 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/ntp4/apps_page.js	View	1 2	5 chunks	+16 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/ntp4/nav_dot.js	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/resources/ntp4/tile_page.js	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

Rick Byers

LGTM The promo-related CSS is getting pretty complicated - seems like it should be possible ...

9 years, 4 months ago (2011-08-10 17:10:28 UTC) #2

Change committed as 96688