Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 7602010: Exclude ServiceProcessStateTest.ForceShutdown from Dr. Memory runs (Closed)

Created:
9 years, 4 months ago by Timur Iskhodzhanov
Modified:
9 years, 4 months ago
CC:
chromium-reviews, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Exclude ServiceProcessStateTest.ForceShutdown from Dr. Memory runs BUG=92144 TBR=bruening Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95974

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory_win32.txt View 1 chunk +3 lines, -0 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Timur Iskhodzhanov
9 years, 4 months ago (2011-08-09 09:07:51 UTC) #1
bruening
http://codereview.chromium.org/7602010/diff/1/tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory_win32.txt File tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory_win32.txt (right): http://codereview.chromium.org/7602010/diff/1/tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory_win32.txt#newcode25 tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory_win32.txt:25: ServiceProcessStateTest.ForceShutdown xref to drmem i#322
9 years, 4 months ago (2011-08-09 16:52:53 UTC) #2
Timur Iskhodzhanov
http://codereview.chromium.org/7602010/diff/1/tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory_win32.txt File tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory_win32.txt (right): http://codereview.chromium.org/7602010/diff/1/tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory_win32.txt#newcode25 tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory_win32.txt:25: ServiceProcessStateTest.ForceShutdown It fails even w/o DrM locally On 2011/08/09 ...
9 years, 4 months ago (2011-08-10 12:16:03 UTC) #3
Timur Iskhodzhanov
9 years, 4 months ago (2011-08-10 12:22:34 UTC) #4
On 2011/08/10 12:16:03, Timur Iskhodzhanov wrote:
>
http://codereview.chromium.org/7602010/diff/1/tools/valgrind/gtest_exclude/un...
> File tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory_win32.txt (right):
> 
>
http://codereview.chromium.org/7602010/diff/1/tools/valgrind/gtest_exclude/un...
> tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory_win32.txt:25:
> ServiceProcessStateTest.ForceShutdown
> It fails even w/o DrM locally
Ah, you're telling this too in i#322

> 
> On 2011/08/09 16:52:53, bruening wrote:
> > xref to drmem i#322

Powered by Google App Engine
This is Rietveld 408576698