Add preliminary Autofill support for the 'autocompletetype' attribute.

Add preliminary Autofill support for the 'autocompletetype' attribute.

BUG=92121
TEST=unit_tests --gtest_filter=FormStructureTest.*Autocompletetype*; browser_tests --gtest_filter=FormManagerTest.WebFormControlElementToFormFieldAutocompletetype


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96131

[dhollowa, 2011-08-09 21:25:22]

http://codereview.chromium.org/7602006/diff/2001/chrome/browser/autofill/form...
File chrome/browser/autofill/form_structure.cc (right):

http://codereview.chromium.org/7602006/diff/2001/chrome/browser/autofill/form...
chrome/browser/autofill/form_structure.cc:231: // Classifies each field in
|fields| based upon its 'autocompletetype'
nit: convention is |autocompletetype|

http://codereview.chromium.org/7602006/diff/2001/chrome/browser/autofill/form...
chrome/browser/autofill/form_structure.cc:245:
Tokenize((*field)->autocomplete_type, ASCIIToUTF16(" "), &types);
Since |autocomplete_type| is coming in from an untrusted source, we should add
code that helps avoid DOS'ing the browser.  A simple length test should be
sufficient.

http://codereview.chromium.org/7602006/diff/2001/chrome/browser/autofill/form...
chrome/browser/autofill/form_structure.cc:247: // TODO(isherman): Handle
sections.
Please log a bug against this and cite the bug number here.

http://codereview.chromium.org/7602006/diff/2001/chrome/browser/autofill/form...
chrome/browser/autofill/form_structure.cc:303: // First, try to detect field
types based on the fields' 'autocompletetype'
nit: convention is |autocompletetype|

http://codereview.chromium.org/7602006/diff/2001/chrome/browser/autofill/form...
File chrome/browser/autofill/form_structure.h (right):

http://codereview.chromium.org/7602006/diff/2001/chrome/browser/autofill/form...
chrome/browser/autofill/form_structure.h:190: // author, via the
'autocompletetype' attribute.
nit: convention is |autocompletetype|

http://codereview.chromium.org/7602006/diff/2001/chrome/browser/autofill/form...
File chrome/browser/autofill/form_structure_unittest.cc (right):

http://codereview.chromium.org/7602006/diff/2001/chrome/browser/autofill/form...
chrome/browser/autofill/form_structure_unittest.cc:471: }
A test for ambiguous input would be helpful.  e.g. "full-name email".

http://codereview.chromium.org/7602006/diff/2001/chrome/renderer/autofill/for...
File chrome/renderer/autofill/form_manager.cc (right):

http://codereview.chromium.org/7602006/diff/2001/chrome/renderer/autofill/for...
chrome/renderer/autofill/form_manager.cc:602:
TrimWhitespace(field->autocomplete_type, TRIM_ALL, &field->autocomplete_type);
This might be the better place to discard unreasonable input.

[Ilya Sherman, 2011-08-09 22:55:03]

http://codereview.chromium.org/7602006/diff/2001/chrome/browser/autofill/form...
File chrome/browser/autofill/form_structure.cc (right):

http://codereview.chromium.org/7602006/diff/2001/chrome/browser/autofill/form...
chrome/browser/autofill/form_structure.cc:231: // Classifies each field in
|fields| based upon its 'autocompletetype'
On 2011/08/09 21:25:23, dhollowa wrote:
> nit: convention is |autocompletetype|

Done.

http://codereview.chromium.org/7602006/diff/2001/chrome/browser/autofill/form...
chrome/browser/autofill/form_structure.cc:245:
Tokenize((*field)->autocomplete_type, ASCIIToUTF16(" "), &types);
On 2011/08/09 21:25:23, dhollowa wrote:
> Since |autocomplete_type| is coming in from an untrusted source, we should add
> code that helps avoid DOS'ing the browser.  A simple length test should be
> sufficient.

Done.

http://codereview.chromium.org/7602006/diff/2001/chrome/browser/autofill/form...
chrome/browser/autofill/form_structure.cc:247: // TODO(isherman): Handle
sections.
On 2011/08/09 21:25:23, dhollowa wrote:
> Please log a bug against this and cite the bug number here.

Done.

http://codereview.chromium.org/7602006/diff/2001/chrome/browser/autofill/form...
chrome/browser/autofill/form_structure.cc:303: // First, try to detect field
types based on the fields' 'autocompletetype'
On 2011/08/09 21:25:23, dhollowa wrote:
> nit: convention is |autocompletetype|

Done.

http://codereview.chromium.org/7602006/diff/2001/chrome/browser/autofill/form...
File chrome/browser/autofill/form_structure.h (right):

http://codereview.chromium.org/7602006/diff/2001/chrome/browser/autofill/form...
chrome/browser/autofill/form_structure.h:190: // author, via the
'autocompletetype' attribute.
On 2011/08/09 21:25:23, dhollowa wrote:
> nit: convention is |autocompletetype|

Done.

http://codereview.chromium.org/7602006/diff/2001/chrome/browser/autofill/form...
File chrome/browser/autofill/form_structure_unittest.cc (right):

http://codereview.chromium.org/7602006/diff/2001/chrome/browser/autofill/form...
chrome/browser/autofill/form_structure_unittest.cc:471: }
On 2011/08/09 21:25:23, dhollowa wrote:
> A test for ambiguous input would be helpful.  e.g. "full-name email".

Does "field2" not cover that case?  ;)

http://codereview.chromium.org/7602006/diff/2001/chrome/renderer/autofill/for...
File chrome/renderer/autofill/form_manager.cc (right):

http://codereview.chromium.org/7602006/diff/2001/chrome/renderer/autofill/for...
chrome/renderer/autofill/form_manager.cc:602:
TrimWhitespace(field->autocomplete_type, TRIM_ALL, &field->autocomplete_type);
On 2011/08/09 21:25:23, dhollowa wrote:
> This might be the better place to discard unreasonable input.

Done.

[dhollowa, 2011-08-09 23:37:43]

LGTM!

[commit-bot: I haz the power, 2011-08-10 05:38:48]

Change committed as 96131