Issue 7601028: [Mac] Polish the infobars.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7601028: [Mac] Polish the infobars. (Closed)

Created:
9 years, 4 months ago by Robert Sesek

Modified:
9 years, 4 months ago

Reviewers:
rohitrao (ping after 24h)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[Mac] Polish the infobars. This makes sure all the text sizes and baselines are correct. Roll GTM DEPS r452:453 to pick up a fix for sizeToFit on rounded texture buttons. BUG=86410 TEST=Anal polish. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96058

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : Typo #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -4 lines)			Patch
M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/infobars/infobar_controller.mm	View	1 2	4 chunks	+12 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/cocoa/translate/before_translate_infobar_controller.mm	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rohitrao (ping after 24h)

LGTM http://codereview.chromium.org/7601028/diff/2001/chrome/browser/ui/cocoa/infobars/infobar_controller.mm File chrome/browser/ui/cocoa/infobars/infobar_controller.mm (right): http://codereview.chromium.org/7601028/diff/2001/chrome/browser/ui/cocoa/infobars/infobar_controller.mm#newcode329 chrome/browser/ui/cocoa/infobars/infobar_controller.mm:329: // to expicitly set the control's font. We ...

9 years, 4 months ago (2011-08-09 17:10:09 UTC) #2

Robert Sesek

9 years, 4 months ago (2011-08-09 17:48:28 UTC) #3

http://codereview.chromium.org/7601028/diff/2001/chrome/browser/ui/cocoa/info...
File chrome/browser/ui/cocoa/infobars/infobar_controller.mm (right):

http://codereview.chromium.org/7601028/diff/2001/chrome/browser/ui/cocoa/info...
chrome/browser/ui/cocoa/infobars/infobar_controller.mm:329: // to expicitly set
the control's font.  We also override the cursor to give
On 2011/08/09 17:10:09, rohitrao wrote:
> While you're here, s/expicitly/explicitly/

Done.

Expand Messages | Collapse Messages