Add Java support directory to plugin lookup list on 10.5

Add Java support directory to plugin lookup list on 10.5

This works around the fact that the Java2 plugin is no longer officially supported for 10.5, and is thus no longer included in the Internet Plug-Ins directories where we expect to find plugins.

BUG=89543
TEST=Open about:plugins on 10.5; Java should be listed.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96224

[stuartmorgan, 2011-08-09 08:24:07]

This should work, but I can't easily get a 10.5 machine. Can you find someone to
build and test this on 10.5?

[Mark Mentovai, 2011-08-09 16:46:44]

LGTM

http://codereview.chromium.org/7601022/diff/1/webkit/plugins/npapi/plugin_lis...
File webkit/plugins/npapi/plugin_list_mac.mm (right):

http://codereview.chromium.org/7601022/diff/1/webkit/plugins/npapi/plugin_lis...
webkit/plugins/npapi/plugin_list_mac.mm:78: // 10.5 includes the Java2 plugin,
but no longer has a symlink to it in
Can you make the comment a bit more specific? This isn’t a property of 10.5 per
se, it’s a property of “Java for Mac OS X 10.5 Update 10.”

You may want to refer directly to
http://developer.apple.com/library/mac/#releasenotes/Java/JavaSnowLeopardUpda...

http://codereview.chromium.org/7601022/diff/1/webkit/plugins/npapi/plugin_lis...
webkit/plugins/npapi/plugin_list_mac.mm:83:
"/System/Library/Java/Support/Deploy.bundle/Contents/Resources/"));
Any reason for the trailing slash? This works just fine without it.

[stuartmorgan1, 2011-08-10 11:10:44]

http://codereview.chromium.org/7601022/diff/1/webkit/plugins/npapi/plugin_lis...
File webkit/plugins/npapi/plugin_list_mac.mm (right):

http://codereview.chromium.org/7601022/diff/1/webkit/plugins/npapi/plugin_lis...
webkit/plugins/npapi/plugin_list_mac.mm:78: // 10.5 includes the Java2 plugin,
but no longer has a symlink to it in
On 2011/08/09 16:46:44, Mark Mentovai wrote:
> Can you make the comment a bit more specific? This isn’t a property of 10.5
per
> se, it’s a property of “Java for Mac OS X 10.5 Update 10.”
> 
> You may want to refer directly to
>
http://developer.apple.com/library/mac/#releasenotes/Java/JavaSnowLeopardUpda...

Done.

http://codereview.chromium.org/7601022/diff/1/webkit/plugins/npapi/plugin_lis...
webkit/plugins/npapi/plugin_list_mac.mm:83:
"/System/Library/Java/Support/Deploy.bundle/Contents/Resources/"));
On 2011/08/09 16:46:44, Mark Mentovai wrote:
> Any reason for the trailing slash? This works just fine without it.

Just copy/paste from terminal autocomplete. Removed.

[Mark Mentovai, 2011-08-10 12:52:56]

LGTM

[commit-bot: I haz the power, 2011-08-10 15:01:15]

Try job failure for 7601022-4001 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2011-08-10 22:27:44]

Change committed as 96224