Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 7601021: Add UMA for register protocol handler. (Closed)

Created:
9 years, 4 months ago by koz (OOO until 15th September)
Modified:
9 years, 4 months ago
CC:
chromium-reviews, Avi (use Gerrit), brettw-cc_chromium.org
Visibility:
Public.

Description

Add UMA for register protocol handler. BUG=92440 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96340

Patch Set 1 #

Patch Set 2 : changed names #

Patch Set 3 : fix compile error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M chrome/browser/custom_handlers/register_protocol_handler_infobar_delegate.cc View 1 3 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_wrapper.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
koz (OOO until 15th September)
Hi Peter, Should these identifiers be using dots or underscores? There seems to be both ...
9 years, 4 months ago (2011-08-09 06:00:09 UTC) #1
Peter Kasting
On 2011/08/09 06:00:09, koz wrote: > Should these identifiers be using dots or underscores? There ...
9 years, 4 months ago (2011-08-09 20:14:58 UTC) #2
koz (OOO until 15th September)
Thanks, Peter. jar, could you take a look?
9 years, 4 months ago (2011-08-11 00:08:37 UTC) #3
jar (doing other things)
re: Naming conventions or histograms. The only significant standard is that names should start with ...
9 years, 4 months ago (2011-08-11 00:20:36 UTC) #4
koz (OOO until 15th September)
On 2011/08/11 00:20:36, jar wrote: > re: Naming conventions or histograms. > > The only ...
9 years, 4 months ago (2011-08-11 04:20:44 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
9 years, 4 months ago (2011-08-11 05:52:48 UTC) #6
commit-bot: I haz the power
9 years, 4 months ago (2011-08-11 08:41:52 UTC) #7
Change committed as 96340

Powered by Google App Engine
This is Rietveld 408576698