Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 7601014: browser: Abstract message box dialog functions into its own header file. (Closed)

Created:
9 years, 4 months ago by tfarina
Modified:
9 years, 4 months ago
CC:
chromium-reviews, ncarter (slow), idana, Raghu Simha, Erik does not do reviews, Paweł Hajdan Jr., achuith+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, brettw-cc_chromium.org, Avi (use Gerrit), estade+watch_chromium.org, tim (not reviewing)
Visibility:
Public.

Description

browser: Abstract message box dialog functions into its own header file. BUG=None TEST=None R=evan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96071

Patch Set 1 : #

Patch Set 2 : compile on chromeos? #

Patch Set 3 : compile on linux_view? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -222 lines) Patch
M chrome/browser/bookmarks/bookmark_utils.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_error_reporter.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/file_manager_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/hang_monitor/hung_plugin_action.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/platform_util.h View 1 chunk +1 line, -14 lines 0 comments Download
M chrome/browser/platform_util_common_linux.cc View 2 chunks +0 lines, -82 lines 0 comments Download
M chrome/browser/platform_util_mac.mm View 1 chunk +0 lines, -28 lines 0 comments Download
M chrome/browser/platform_util_win.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/process_singleton_win.cc View 2 chunks +4 lines, -6 lines 0 comments Download
A chrome/browser/simple_message_box.h View 1 chunk +30 lines, -0 lines 0 comments Download
M chrome/browser/speech/speech_input_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/sync_setup_flow.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 2 chunks +1 line, -2 lines 0 comments Download
A chrome/browser/ui/cocoa/simple_message_box_mac.mm View 1 chunk +43 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/infobars/infobar_gtk.cc View 1 chunk +0 lines, -1 line 0 comments Download
A + chrome/browser/ui/gtk/simple_message_box_gtk.cc View 5 chunks +23 lines, -49 lines 0 comments Download
M chrome/browser/ui/profile_error_dialog.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/tests/browser_uitest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/about_chrome_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
A chrome/browser/ui/views/simple_message_box_win.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 6 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
Evan, if you don't feel comfortable reviewing this, just says and I'll try to find ...
9 years, 4 months ago (2011-08-09 13:09:24 UTC) #1
Evan Martin
I like the idea of the change (I never liked "platform_util" as a namespace) but ...
9 years, 4 months ago (2011-08-09 15:24:21 UTC) #2
tfarina
On 2011/08/09 15:24:21, Evan Martin wrote: > I like the idea of the change (I ...
9 years, 4 months ago (2011-08-09 19:00:14 UTC) #3
tfarina
On 2011/08/09 15:24:21, Evan Martin wrote: > I like the idea of the change (I ...
9 years, 4 months ago (2011-08-09 20:04:14 UTC) #4
Avi (use Gerrit)
9 years, 4 months ago (2011-08-09 20:12:20 UTC) #5
I'm no platform expert, but this is just some shifting code. LGTM

Powered by Google App Engine
This is Rietveld 408576698