Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1307)

Issue 7601011: Fix resource loads dropped when iframe is transferred to a new window and original window closes. (Closed)

Created:
9 years, 4 months ago by Dmitry Titov
Modified:
9 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix resource loads dropped when iframe is transferred to a new window and original window closes. BUG=55200 TEST=MagicIframeBrowserTest.TransferIframeCloseWindow

Patch Set 1 #

Patch Set 2 : Fix crash in tests (RenderThread::current() is NULL) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -10 lines) Patch
M chrome/browser/magic_iframe_browsertest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host.h View 2 chunks +7 lines, -0 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host.cc View 3 chunks +24 lines, -0 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_request_info.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/common/resource_dispatcher.h View 3 chunks +10 lines, -3 lines 0 comments Download
M content/common/resource_dispatcher.cc View 5 chunks +26 lines, -2 lines 0 comments Download
M content/common/resource_dispatcher_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/resource_messages.h View 1 chunk +6 lines, -0 lines 0 comments Download
M content/renderer/render_view.cc View 1 3 chunks +10 lines, -1 line 0 comments Download
M webkit/glue/resource_loader_bridge.h View 1 chunk +5 lines, -0 lines 0 comments Download
M webkit/glue/resource_loader_bridge.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/weburlloader_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Dmitry Titov
The issue here is when iframe gets reparented to another page and the original page ...
9 years, 4 months ago (2011-08-09 00:04:31 UTC) #1
jam
With this change, the chrome code would have 3 ids for a resource (routing/request/identifier), which ...
9 years, 4 months ago (2011-08-09 02:49:04 UTC) #2
Dmitry Titov
On 2011/08/09 02:49:04, John Abd-El-Malek wrote: > With this change, the chrome code would have ...
9 years, 4 months ago (2011-08-09 05:45:38 UTC) #3
jam
On 2011/08/09 05:45:38, Dmitry Titov wrote: > On 2011/08/09 02:49:04, John Abd-El-Malek wrote: > > ...
9 years, 4 months ago (2011-08-09 15:53:45 UTC) #4
jam
another option, which Darin recommended, is to avoid doing this per request. that would avoid ...
9 years, 4 months ago (2011-08-09 19:07:15 UTC) #5
Dmitry Titov
9 years, 4 months ago (2011-08-10 17:54:29 UTC) #6
Thanks for feedback! I will close this patch, there is a different idea on how
to do it (from Darin), I'll give it a try.

Powered by Google App Engine
This is Rietveld 408576698