Issue 7600023: Proper EULA handling for quick-enable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7600023: Proper EULA handling for quick-enable. (Closed)

Created:
9 years, 4 months ago by grt (UTC plus 2)

Modified:
9 years, 4 months ago

Reviewers:
erikwright (departed), commit-bot: I haz the power

CC:
chromium-reviews, Paweł Hajdan Jr., robert

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Description

Proper EULA handling for quick-enable. Mark the binaries' EULA as having been accepted when GCF is installed via quick-enable. This causes Google Update to start updating the multi-install. Chrome's EULA will still be required on first-run. BUG=88544 TEST=1) Do a multi-install OEM install of Chrome for which the EULA is required. Alternatively, install system-level multi-install Chrome and then manually add eulaaccepted=0 to Chrome's and the binaries' ClientState keys. 2) Visit the GCF download page and install GCF via quick-enable. 3) Verify that eulaaccepted=1 is written to the binaries' ClientStateMedium key. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96386

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -7 lines)			Patch
M	chrome/installer/setup/chrome_frame_quick_enable.cc	View	2 chunks	+27 lines, -0 lines	0 comments	Download
M	chrome/installer/setup/setup_main.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/installer/util/google_update_settings.h	View	3 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/installer/util/google_update_settings.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/installer/util/google_update_settings_unittest.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Change committed as 96386

Expand Messages | Collapse Messages