src/arm/lithium-codegen-arm.cc - Issue 7600019: Fixed extremely important, mission-critical presubmit warnings...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/lithium-codegen-arm.cc

Issue 7600019: Fixed extremely important, mission-critical presubmit warnings... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/lithium-codegen-arm.cc

===================================================================

--- src/arm/lithium-codegen-arm.cc (revision 8859)

+++ src/arm/lithium-codegen-arm.cc (working copy)

@@ -1679,8 +1679,8 @@

__ b(ne, &not_heap_number);

__ vldr(dbl_scratch, FieldMemOperand(reg, HeapNumber::kValueOffset));

__ VFPCompareAndSetFlags(dbl_scratch, 0.0);

- __ b(vs, false_label); // NaN -> false.

- __ b(eq, false_label); // +0, -0 -> false.

+ __ b(vs, false_label); // NaN -> false.

+ __ b(eq, false_label); // +0, -0 -> false.

__ b(true_label);

__ bind(&not_heap_number);

} else if (expected.Contains(ToBooleanStub::INTERNAL_OBJECT)) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »