Issue 7600016: WebKitClient::createThread and associated implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7600016: WebKitClient::createThread and associated implementation (Closed)

Created:
9 years, 4 months ago by nduca

Modified:
9 years, 4 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, Paweł Hajdan Jr., darin-cc_chromium.org, brettw-cc_chromium.org, aelias_OOO_until_Jul13

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

This is an implementation of WebThread to allow WebKit to create threads that are backed by base::MessageThreads and thus base's MessageLoops. Doing this allows Chromium services to be more easily used on webkit threads. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96946

Patch Set 1 #

Patch Set 2 : Remove thread changes. #

Patch Set 3 : Switch to using Task ptr on interface. #

Patch Set 4 : For the trybots #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -1 line)			Patch
M	base/threading/thread.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/webkit_glue.gypi	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/glue/webkitclient_impl.h	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	webkit/glue/webkitclient_impl.cc	View	1 2 3	2 chunks	+5 lines, -0 lines	0 comments	Download
A	webkit/glue/webthread_impl.h	View	1 2	1 chunk	+26 lines, -0 lines	0 comments	Download
A	webkit/glue/webthread_impl.cc	View	1 2 3	1 chunk	+45 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages