Add export_v8_tarball.py, a new tool to also export

Add export_v8_tarball.py, a new tool to also export
standalone tarballs for V8.

This will be useful for Linux distributions packaging
shared library packages for V8.

BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96099

[Paweł Hajdan Jr., 2011-08-09 19:05:23]

+Chase, could you take a look? Nicolas seems OOO.

[cmp, 2011-08-09 21:29:38]

http://codereview.chromium.org/7600011/diff/1/tools/export_tarball/export_v8_...
File tools/export_tarball/export_v8_tarball.py (right):

http://codereview.chromium.org/7600011/diff/1/tools/export_tarball/export_v8_...
tools/export_tarball/export_v8_tarball.py:25: _V8_MAJOR_VERSION_PATTERN =
re.compile(r"#define\s+MAJOR_VERSION\s+(.*)")
" -> ' here and below

http://codereview.chromium.org/7600011/diff/1/tools/export_tarball/export_v8_...
tools/export_tarball/export_v8_tarball.py:68: tarfile.TarFile.add(self, name,
arcname=arcname, recursive=recursive)
it would probably be simpler and less error-prone to just use 'tar' from the
command line.  we see cases where we go out of our way to use python modules to
compress archives and they inevitably lead to memory issues in the same python
process.

can you use RunCommand or subprocess here after manipulating a directory's
contents to suit your needs?

http://codereview.chromium.org/7600011/diff/1/tools/export_tarball/export_v8_...
tools/export_tarball/export_v8_tarball.py:100: if __name__ == "__main__":
use single quotes, instead of double quotes

[Paweł Hajdan Jr., 2011-08-09 23:00:16]

http://codereview.chromium.org/7600011/diff/1/tools/export_tarball/export_v8_...
File tools/export_tarball/export_v8_tarball.py (right):

http://codereview.chromium.org/7600011/diff/1/tools/export_tarball/export_v8_...
tools/export_tarball/export_v8_tarball.py:25: _V8_MAJOR_VERSION_PATTERN =
re.compile(r"#define\s+MAJOR_VERSION\s+(.*)")
On 2011/08/09 21:29:38, cmp wrote:
> " -> ' here and below

Done.

http://codereview.chromium.org/7600011/diff/1/tools/export_tarball/export_v8_...
tools/export_tarball/export_v8_tarball.py:68: tarfile.TarFile.add(self, name,
arcname=arcname, recursive=recursive)
On 2011/08/09 21:29:38, cmp wrote:
> can you use RunCommand or subprocess here after manipulating a directory's
> contents to suit your needs?

Actually this code is taken from export_tarball.py, which is very well tested
for months on a much larger tarball (150 MB vs. 9 MB). I'd prefer to leave this
as-is.

http://codereview.chromium.org/7600011/diff/1/tools/export_tarball/export_v8_...
tools/export_tarball/export_v8_tarball.py:100: if __name__ == "__main__":
On 2011/08/09 21:29:38, cmp wrote:
> use single quotes, instead of double quotes

Done.

[cmp, 2011-08-09 23:09:42]

lgtm

http://codereview.chromium.org/7600011/diff/1/tools/export_tarball/export_v8_...
File tools/export_tarball/export_v8_tarball.py (right):

http://codereview.chromium.org/7600011/diff/1/tools/export_tarball/export_v8_...
tools/export_tarball/export_v8_tarball.py:68: tarfile.TarFile.add(self, name,
arcname=arcname, recursive=recursive)
Cool, as long as it works well and is well-tested!