Grab bag of bugfixes for Lion fullscreen mode.

chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.h"
 
+#include "base/mac/mac_util.h"
 #include "base/string_util.h"
 #include "base/sys_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"  // IDC_*
 #include "chrome/browser/ui/browser_list.h"
 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
 #import "chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.h"
 #import "chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.h"
 #import "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util_mac.h"
@@ skipping 374 matching lines @@
 
   if (observer && observer->OnDoCommandBySelector(cmd)) {
     // The observer should already be aware of any changes to the text, so
     // setting |textChangedByKeyEvents_| to NO to prevent its OnDidChange()
     // method from being called unnecessarily.
     textChangedByKeyEvents_ = NO;
     return;
   }
 
   // If the escape key was pressed and no revert happened and we're in
-  // fullscreen mode, make it resign key.
+  // presentaion mode, make the window resign key.  If we're in Lion full-screen
+  // mode, Esc should toggle out of fullscreen.

[Mark Mentovai, 2011/08/09 16:41:15]

So the idea is that in presentation mode, we take focus away from the omnibox,
which causes the overlay to slide up as long as the mouse isn’t up there. In
non-presentation mode on Lion, we exit full-screen.

What about Esc to exit full-screen when the TabContents is focused?

[rohitrao (ping after 24h), 2011/08/09 16:46:23]

That's the other part of the equation, and once that's in, mashing on Esc enough
will eventually take you out of fullscreen mode.  I looked at implementing that,
but I'm not really sure where that code should live, or how it should interact
with all of the key handling code in RWHVMac.  I think that whoever wrote the
IME code would be best person to tackle this.

In the meantime, I don't know if a half-solution is better than no solution.  I
could certainly make reasonable arguments either way.

[Mark Mentovai, 2011/08/09 16:48:52]

Seems like if we’re going to make enough Esc keypresses from the TabContents
exit full-screen anyway, we might as well just let an Esc from here allays give
focus back to the TabContents.

   if (cmd == @selector(cancelOperation:)) {
     BrowserWindowController* windowController =
         [BrowserWindowController browserWindowControllerForView:self];
     if ([windowController inPresentationMode]) {
       [windowController focusTabContents];
+      textChangedByKeyEvents_ = NO;
+      return;
+    } else if ([windowController isFullscreen] &&
+               base::mac::IsOSLionOrLater()) {
+      [windowController setFullscreen:NO];
+      textChangedByKeyEvents_ = NO;
       return;
     }
   }
 
   [super doCommandBySelector:cmd];
 }
 
 - (void)setAttributedString:(NSAttributedString*)aString {
   NSTextStorage* textStorage = [self textStorage];
   DCHECK(textStorage);
   [textStorage setAttributedString:aString];
 
   // The text has been changed programmatically. The observer should know
   // this change, so setting |textChangedByKeyEvents_| to NO to
   // prevent its OnDidChange() method from being called unnecessarily.
   textChangedByKeyEvents_ = NO;
 }
 
 - (void)mouseDown:(NSEvent*)theEvent {
   // Close the popup before processing the event.
   AutocompleteTextFieldObserver* observer = [self observer];
   if (observer)
     observer->ClosePopup();
 
   [super mouseDown:theEvent];
 }
 
 @end