Issue 7599027: Add support for XMLHttpRequests to the webRequest API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7599027: Add support for XMLHttpRequests to the webRequest API (Closed)

Created:
9 years, 4 months ago by jochen (gone - plz use gerrit)

Modified:
9 years, 4 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Add support for XMLHttpRequests to the webRequest API BUG=80230 TEST=api tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96008

Patch Set 1 #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+121 lines, -4 lines)			Patch
M	chrome/browser/extensions/extension_webrequest_api.cc	View	2 chunks	+4 lines, -0 lines	1 comment	Download
M	chrome/common/extensions/api/extension_api.json	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/docs/experimental.webRequest.html	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/webrequest/events/test.html	View	3 chunks	+100 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/webrequest/events/xhr/a.html	View	1 chunk	+12 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/webrequest/events/xhr/data.json	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

The original CL triggered a compiler bug in gcc 4.4 (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43949) To work around this, ...

9 years, 4 months ago (2011-08-09 14:56:53 UTC) #1

Matt Perry

9 years, 4 months ago (2011-08-09 16:58:42 UTC) #2

LGTM with below fixed

http://codereview.chromium.org/7599027/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_webrequest_api.cc (right):

http://codereview.chromium.org/7599027/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_webrequest_api.cc:73:
ResourceType::SUB_RESOURCE,
this needs to be LAST_TYPE since we look up type based on the string. also,
please add a comment explaining why we double the last entry.

Expand Messages | Collapse Messages