Fix a bug in named getter/setter compilation.

Fix a bug in named getter/setter compilation.

Because these are function literals that have an associated name, we were
compiling them as if they were named function expressions.  This is
incorrect, the property name should not be in scope.

R=vegorov@chromium.org
BUG=
TEST=

Committed: http://code.google.com/p/v8/source/detail?r=8863

[Vyacheslav Egorov (Chromium), 2011-08-09 12:24:55]

LGTM

http://codereview.chromium.org/7599024/diff/1/src/parser.cc
File src/parser.cc (right):

http://codereview.chromium.org/7599024/diff/1/src/parser.cc#newcode662
src/parser.cc:662: true,  // is_expression
Can we change it to pass FunctionLiteralType instead of booleans?

http://codereview.chromium.org/7599024/diff/1/src/parser.cc#newcode3834
src/parser.cc:3834: type != DECLARATION,
Ditto.

http://codereview.chromium.org/7599024/diff/1/src/parser.cc#newcode3834
src/parser.cc:3834: type != DECLARATION,
Ditto.

[Kevin Millikin (Chromium), 2011-08-09 12:42:47]

http://codereview.chromium.org/7599024/diff/1/src/parser.cc
File src/parser.cc (right):

http://codereview.chromium.org/7599024/diff/1/src/parser.cc#newcode662
src/parser.cc:662: true,  // is_expression
On 2011/08/09 12:24:57, Vyacheslav Egorov wrote:
> Can we change it to pass FunctionLiteralType instead of booleans?

Good idea.  Done.  I had to move it to ast to avoid a circular include, so
FunctionLiteralType ==> FunctionLiteral::Type, which is kind of cute and still
reads OK.