Chromium Code Reviews| Index: remoting/jingle_glue/jingle_info_request.cc |
| diff --git a/remoting/jingle_glue/jingle_info_request.cc b/remoting/jingle_glue/jingle_info_request.cc |
| index 1dabf2625e8fe0af0f3d6c891bb4f054542edde9..2c3a39c0bd005d03fee2548f7aa6647985edc20a 100644 |
| --- a/remoting/jingle_glue/jingle_info_request.cc |
| +++ b/remoting/jingle_glue/jingle_info_request.cc |
| @@ -57,13 +57,20 @@ void JingleInfoRequest::OnResponse(const buzz::XmlElement* stanza) { |
| int port; |
| if (!base::StringToInt(port_str, &port)) { |
| LOG(WARNING) << "Unable to parse port in stanza" << stanza->Str(); |
| - } else { |
| + continue; |
| + } |
| + |
| + if (host_resolver_factory_) { |
| net::IPAddressNumber ip_number; |
| HostResolver* resolver = host_resolver_factory_->CreateHostResolver(); |
| stun_dns_requests_.insert(resolver); |
| resolver->SignalDone.connect( |
| this, &JingleInfoRequest::OnStunAddressResponse); |
| resolver->Resolve(talk_base::SocketAddress(host, port)); |
| + } else { |
| + // If there is no |host_resolver_factory_|, we're not sandboxed, so |
| + // we can let libjingle itself do the DNS resolution. |
| + stun_hosts_.push_back(talk_base::SocketAddress(host, port)); |
|
Wez
2011/08/11 20:00:27
This doesn't seem related to the rest of the CL?
awong
2011/08/11 23:54:54
Yesish. Without it, when NAT traversal is enabled
|
| } |
| } |
| } |