Issue 7599006: Fix GOOGLE_CHROME_BUILD case. TBR=estade

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7599006: Fix GOOGLE_CHROME_BUILD case. TBR=estade (Closed)

Created:
9 years, 4 months ago by Tom Sepez

Modified:
9 years, 4 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix GOOGLE_CHROME_BUILD case. TBR=estade Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95866

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/ui/webui/print_preview_data_source.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

9 years, 4 months ago (2011-08-08 20:13:45 UTC) #2

lgtm

-- Evan Stade


On Mon, Aug 8, 2011 at 1:09 PM, <tsepez@chromium.org> wrote:

> Reviewers: Evan Stade,
>
> Message:
> blasted #ifdefs ... sorry about that.
>
> Description:
> Fix GOOGLE_CHROME_BUILD case. TBR=estade
> Committed: http://src.chromium.org/**viewvc/chrome?view=rev&**
> revision=95866<http://src.chromium.org/viewvc/chrome?view=rev&revision=95866>
>
> Please review this at
http://codereview.chromium.**org/7599006/<http://codereview.chromium.org/7599...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>  M     chrome/browser/ui/webui/print_**preview_data_source.cc
>
>
> Index: chrome/browser/ui/webui/print_**preview_data_source.cc
> ==============================**==============================**=======
> --- chrome/browser/ui/webui/print_**preview_data_source.cc
>  (revision 95850)
> +++ chrome/browser/ui/webui/print_**preview_data_source.cc        (working
> copy)
> @@ -29,8 +29,8 @@
>   AddLocalizedString("title", IDS_PRINT_PREVIEW_TITLE);
>   AddLocalizedString("loading", IDS_PRINT_PREVIEW_LOADING);
>  #if defined(GOOGLE_CHROME_BUILD)
> -  AddString("noPlugin", l10n_util::GetStringFUTF8(
> -      IDS_PRINT_PREVIEW_NO_PLUGIN, ASCIIToUTF16("chrome://**plugins/"));
> +  AddString("noPlugin", l10n_util::GetStringFUTF16(
> +      IDS_PRINT_PREVIEW_NO_PLUGIN, ASCIIToUTF16("chrome://**plugins/")));
>  #else
>   AddLocalizedString("noPlugin", IDS_PRINT_PREVIEW_NO_PLUGIN);
>  #endif
>
>
>

Expand Messages | Collapse Messages