Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1595)

Issue 7599005: remove _p.c files to avoid link errors when incremental linking (Closed)

Created:
9 years, 4 months ago by scottmg
Modified:
9 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

remove _p.c files to avoid link errors when incremental linking As far as I can tell, the _p.c files should only be included into a proxy when calling across domains. When linking incrementally it appears those files aren't dead-stripped which causes unresolved external references to CStdStubBuffer_Release. BUG=92175 TEST=no new functionality Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96669

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M third_party/iaccessible2/iaccessible2.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/isimpledom/isimpledom.gyp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scottmg
9 years, 4 months ago (2011-08-09 23:59:57 UTC) #1
dmazzoni
LGTM. Just tested building this and testing accessibility APIs, everything works great. Thanks for the ...
9 years, 4 months ago (2011-08-12 21:19:45 UTC) #2
commit-bot: I haz the power
9 years, 4 months ago (2011-08-13 02:38:34 UTC) #3
Change committed as 96669

Powered by Google App Engine
This is Rietveld 408576698