Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 7598037: Re-enable stripping to produce an MH_DYLIB_STUB for closure_blocks_leopard_compat_stub (Closed)

Created:
9 years, 4 months ago by Mark Mentovai
Modified:
9 years, 4 months ago
Reviewers:
TVL
CC:
chromium-reviews
Visibility:
Public.

Description

Re-enable stripping to produce an MH_DYLIB_STUB for closure_blocks_leopard_compat_stub. This was originally checked in at r95892, but the stripping was disabled in r95895 because the original implementation resulted in a double-strip, and you can't strip something again once it's been turned into an MH_DYLIB_STUB. BUG=91978 TEST=Builds remain green Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96025

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -23 lines) Patch
M chrome/browser/mac/closure_blocks_leopard_compat.h View 2 chunks +11 lines, -12 lines 0 comments Download
M chrome/browser/mac/closure_blocks_leopard_compat.S View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +27 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Mentovai
9 years, 4 months ago (2011-08-09 16:26:04 UTC) #1
TVL
9 years, 4 months ago (2011-08-09 16:30:49 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698