Issue 7598034: Make presubmit check happier with GYP.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7598034: Make presubmit check happier with GYP. (Closed)

Created:
9 years, 4 months ago by Vitaly Repeshko

Modified:
9 years, 4 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
	M	tools/presubmit.py	View		1 chunk	+11 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

Jakob Kummerow

9 years, 4 months ago (2011-08-09 13:45:02 UTC) #2

LGTM, thanks. It was on my ToDo list to clean this up.