Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 7598027: Proxy API: Renaming sample extension to reduce user confusion. (Closed)

Created:
9 years, 4 months ago by Mike West
Modified:
9 years, 4 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org
Visibility:
Public.

Description

Proxy API: Renaming sample extension to reduce user confusion. R=pamg@chromium.org BUG=90592 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95979

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
chrome/common/extensions/docs/examples/extensions/proxy_configuration.zip View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/proxy_configuration/_locales/en/messages.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/extensions/proxy_configuration/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/samples.html View 2 chunks +2 lines, -2 lines 1 comment Download
M chrome/common/extensions/docs/samples.json View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mike West
9 years, 4 months ago (2011-08-09 09:06:53 UTC) #1
Pam (message me for reviews)
LGTM. Is the .zip file new, and included intentionally? - Pam http://codereview.chromium.org/7598027/diff/1/chrome/common/extensions/docs/samples.html File chrome/common/extensions/docs/samples.html (right): ...
9 years, 4 months ago (2011-08-09 09:19:41 UTC) #2
Use mkwst_at_chromium.org plz.
9 years, 4 months ago (2011-08-09 10:05:19 UTC) #3
On Tue, Aug 9, 2011 at 11:19 AM, <pam@chromium.org> wrote:

> LGTM.
>
> Is the .zip file new, and included intentionally?
>

Zip file is the bundled extension, rebuilt by
`chrome/common/extensions/docs/build/build.py`, which needs to be done any
time sample code is updated. So, yes, and yes. :)

I'll land this shortly, thanks!

-Mike

Powered by Google App Engine
This is Rietveld 408576698