Revert 95441

Revert 95441

This attempted fix for the bug referenced below did not help.

Original message:

TaskClosureAdapter::Run does not invoke the task if it is null.

This is an attempt to fix http://crbug.com/81449. If this actually fixes it then there is probably something more fundamentally wrong.

BUG=81449

[apatrick_chromium, 2011-08-08 22:16:03]

So the good news is there wasn't a subtle bug in the task system. The bad news
is we still have a top crasher :(

[darin (slow to review), 2011-08-08 22:39:24]

LGTM

not sure if i should be sad or happy

-darin


On Mon, Aug 8, 2011 at 3:16 PM, <apatrick@chromium.org> wrote:

> Reviewers: darin,
>
> Message:
> So the good news is there wasn't a subtle bug in the task system. The bad
> news
> is we still have a top crasher :(
>
> Description:
> Revert 95441
>
> This attempted fix for the bug referenced below did not help.
>
> Original message:
>
> TaskClosureAdapter::Run does not invoke the task if it is null.
>
> This is an attempt to fix http://crbug.com/81449. If this actually fixes
> it then
> there is probably something more fundamentally wrong.
>
> BUG=81449
>
> Please review this at
http://codereview.chromium.**org/7598015/<http://codereview.chromium.org/7598...
>
> SVN Base: svn://chrome-svn/chrome/trunk/**src/
>
> Affected files:
>  M     base/task.cc
>
>
> Index: base/task.cc
> ==============================**==============================**=======
> --- base/task.cc        (revision 95857)
> +++ base/task.cc        (working copy)
> @@ -53,11 +53,9 @@
>  }
>
>  void TaskClosureAdapter::Run() {
> -  if (task_) {
> -    task_->Run();
> -    delete task_;
> -    task_ = NULL;
> -  }
> +  task_->Run();
> +  delete task_;
> +  task_ = NULL;
>  }
>
>  // Don't leak tasks by default.
>
>
>

[commit-bot: I haz the power, 2011-08-09 01:44:22]

Change committed as 95931