Issue 7598006: Add OVERRIDE to all RenderWidgetHostView implementations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7598006: Add OVERRIDE to all RenderWidgetHostView implementations (Closed)

Created:
9 years, 4 months ago by Evan Martin

Modified:
9 years, 4 months ago

Reviewers:
tony

CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Add OVERRIDE to all RenderWidgetHostView implementations Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95900

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -51 lines)			Patch
	M	chrome/browser/renderer_host/render_widget_host_view_mac.h	View		1 chunk	+4 lines, -3 lines	0 comments	Download
	M	content/browser/renderer_host/test_render_view_host.h	View		2 chunks	+47 lines, -48 lines	0 comments	Download

Total messages: 2 (0 generated)

Evan Martin

The test overrode some functions that no longer existed...

9 years, 4 months ago (2011-08-08 19:34:11 UTC) #1

LGTM