Issue 7598002: Fix up close button on mac not centering vertically in the download shelf in fullscreen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7598002: Fix up close button on mac not centering vertically in the download shelf in fullscreen. (Closed)

Created:
9 years, 4 months ago by dmac

Modified:
9 years, 4 months ago

Reviewers:
Nico, rohitrao (ping after 24h)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix up close button on mac not centering vertically in the download shelf in fullscreen. BUG=91716 TEST=Download something. Hit cmd-shift-f for fullscreen. close box should stay centered vertically. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96183

Patch Set 1 #

Total comments: 1

Patch Set 2 : rounded #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
	M	chrome/browser/ui/cocoa/hover_close_button.mm	View	1	2 chunks	+11 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nico

9 years, 4 months ago (2011-08-08 18:23:06 UTC) #2

LGTM

http://codereview.chromium.org/7598002/diff/1/chrome/browser/ui/cocoa/hover_c...
File chrome/browser/ui/cocoa/hover_close_button.mm (right):

http://codereview.chromium.org/7598002/diff/1/chrome/browser/ui/cocoa/hover_c...
chrome/browser/ui/cocoa/hover_close_button.mm:144: destRect.origin.y =
(NSHeight(destRect) / 2) - (NSHeight(imageRect) / 2);
Do you want to clamp this to integer coordinates?

Expand Messages | Collapse Messages